ci(repo): scope the machine and custom integration suites to the packages they load

These suites build their apps inside their tests instead of selecting long-running apps by id. The dependency check now accepts that as long as the tagged tests reference at least one app config, so suites whose apps can't be found still can't be narrowed.

Author: austincalvelage

integration/presets/__tests__/suiteBuildDependencies.test.ts

@@ -60,11 +60,13 @@ beforeAll(async () => {
   ({ appConfigs } = await import('..'));
 });
 
-const packagesLoadedBy = (suite: string) => {
+const appsLoadedBy = (suite: string) => {
   const { appIds, tag } = parseScript(suite);
-  const longRunning = (
-    appConfigs.longRunningApps.getByPattern(appIds!) as unknown as { config: ApplicationConfig }[]
-  ).map(app => app.config);
+  const longRunning = appIds
+    ? (appConfigs.longRunningApps.getByPattern(appIds) as unknown as { config: ApplicationConfig }[]).map(
+        app => app.config,
+      )
+    : [];
 
   const tagPattern = new RegExp(`${tag}(?![\\w-])`);
   const taggedSources = listTestFiles(testsDir)
@@ -80,7 +82,12 @@ const packagesLoadedBy = (suite: string) => {
     [...source.matchAll(/addDependency\(\s*'(@clerk\/[\w-]+)',\s*PKGLAB\s*\)/g)].map(([, name]) => name),
   );
 
-  return [...[...longRunning, ...referenced].flatMap(config => config.pkglabDependencies), ...addedInTests];
+  return { configs: [...longRunning, ...referenced], addedInTests };
+};
+
+const packagesLoadedBy = (suite: string) => {
+  const { configs, addedInTests } = appsLoadedBy(suite);
+  return [...configs.flatMap(config => config.pkglabDependencies), ...addedInTests];
 };
 
 describe('scoped integration suites declare the builds they load', () => {
@@ -93,11 +100,14 @@ describe('scoped integration suites declare the builds they load', () => {
   });
 
   describe.each(scopedSuites)('$suite', ({ suite, dependsOn }) => {
-    it('selects its apps with E2E_APP_ID and a --grep tag', () => {
-      const { script, appIds, tag } = parseScript(suite);
+    it('selects its tests with a --grep tag and its apps by id or from its tagged tests', () => {
+      const { script, tag } = parseScript(suite);
       expect(script, `package.json has no test:integration:${suite} script`).toBeDefined();
-      expect(appIds, `test:integration:${suite} must set E2E_APP_ID to be scoped`).toBeDefined();
       expect(tag, `test:integration:${suite} must pass --grep @tag to be scoped`).toBeDefined();
+      expect(
+        appsLoadedBy(suite).configs.length,
+        `test:integration:${suite} must set E2E_APP_ID or its tagged tests must use appConfigs apps to be scoped`,
+      ).toBeGreaterThan(0);
     });
 
     it('depends on exactly the builds of the packages its fixtures and harness load', () => {

turbo.json

@@ -763,6 +763,23 @@
       "outputLogs": "new-only"
     },
     "//#test:integration:machine": {
+      "dependsOn": [
+        "@clerk/astro#build",
+        "@clerk/backend#build",
+        "@clerk/clerk-js#build",
+        "@clerk/express#build",
+        "@clerk/fastify#build",
+        "@clerk/hono#build",
+        "@clerk/localizations#build",
+        "@clerk/nextjs#build",
+        "@clerk/nuxt#build",
+        "@clerk/react-router#build",
+        "@clerk/shared#build",
+        "@clerk/tanstack-react-start#build",
+        "@clerk/testing#build",
+        "@clerk/ui#build",
+        "@clerk/vue#build"
+      ],
       "env": [
         "CLEANUP",
         "CLERK_E2E_OAUTH_PROVIDER_CLIENT_SECRET",
@@ -772,26 +789,19 @@
         "INTEGRATION_INSTANCE_KEYS",
         "INTEGRATION_STAGING_INSTANCE_KEYS"
       ],
-      "inputs": [
-        "integration/**",
-        "packages/*/package.json",
-        "packages/*/src/**",
-        "packages/*/tsconfig.json",
-        "packages/*/tsconfig.build.json",
-        "packages/*/tsconfig.declarations.json",
-        "packages/*/tsdown.config.*",
-        "packages/*/tsup.config.*",
-        "packages/*/rspack.config.*",
-        "packages/*/vite.config.*",
-        "!packages/*/src/**/*.test.*",
-        "!packages/*/src/**/__tests__/**",
-        "!packages/*/src/**/__mocks__/**",
-        "!packages/*/src/**/__snapshots__/**"
-      ],
+      "inputs": ["integration/**", "!integration/playwright-report/**", "!integration/test-results/**"],
       "outputs": ["integration/playwright-report/**"],
       "outputLogs": "new-only"
     },
     "//#test:integration:custom": {
+      "dependsOn": [
+        "@clerk/backend#build",
+        "@clerk/clerk-js#build",
+        "@clerk/react#build",
+        "@clerk/shared#build",
+        "@clerk/testing#build",
+        "@clerk/ui#build"
+      ],
       "env": [
         "CLEANUP",
         "CLERK_E2E_OAUTH_PROVIDER_CLIENT_SECRET",
@@ -801,22 +811,7 @@
         "INTEGRATION_INSTANCE_KEYS",
         "INTEGRATION_STAGING_INSTANCE_KEYS"
       ],
-      "inputs": [
-        "integration/**",
-        "packages/*/package.json",
-        "packages/*/src/**",
-        "packages/*/tsconfig.json",
-        "packages/*/tsconfig.build.json",
-        "packages/*/tsconfig.declarations.json",
-        "packages/*/tsdown.config.*",
-        "packages/*/tsup.config.*",
-        "packages/*/rspack.config.*",
-        "packages/*/vite.config.*",
-        "!packages/*/src/**/*.test.*",
-        "!packages/*/src/**/__tests__/**",
-        "!packages/*/src/**/__mocks__/**",
-        "!packages/*/src/**/__snapshots__/**"
-      ],
+      "inputs": ["integration/**", "!integration/playwright-report/**", "!integration/test-results/**"],
       "outputs": ["integration/playwright-report/**"],
       "outputLogs": "new-only"
     },