Skip to content

Commit aa9a6a3

Browse files
test(mosaic): avoid session cookie buildup in feature tests (#10586)
1 parent 9f8fe59 commit aa9a6a3

4 files changed

Lines changed: 21 additions & 1 deletion

File tree

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

‎packages/mosaic/docs/testing.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,9 @@ in [Test placement](#test-placement).
178178
`ClerkContextProvider` and `MosaicProvider`, loads Clerk, and returns
179179
`{ clerk, navigate, rerender, ... }`.
180180
`navigate` is the router Clerk was loaded with, called with the path.
181+
It loads Clerk with `standardBrowser: false`. A test's Clerk is never
182+
disposed, and its cookie service would otherwise write cookies into later
183+
tests.
181184

182185
The setup file (`vitest.setup.browser.mts`) starts the worker and focuses the
183186
window. Before each test it moves FAPI to a new host, so a request a previous

‎packages/mosaic/src/__tests__/feature/fake-fapi-isolation.feature.test.tsx‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,4 +36,12 @@ describe('fake FAPI isolation between tests', () => {
3636
expect(memberships.requests).toHaveLength(0);
3737
memberships.release();
3838
});
39+
40+
it('does not let any Clerk write session cookies', async () => {
41+
const user = fapiUser({ id: 'user_1' });
42+
serveFapi({ client: fapiClient([fapiSession({ id: 'sess_1', user })]) });
43+
const { clerk } = await renderWithClerk(<div />);
44+
expect(await clerk.session?.getToken()).toEqual(expect.any(String));
45+
expect(document.cookie).not.toMatch(/(?:^|; )__session/);
46+
});
3947
});

‎packages/mosaic/src/__tests__/feature/render.tsx‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,14 @@ export async function renderWithClerk(
3333
);
3434
let current = ui;
3535
const view = render(wrap(current));
36-
await act(() => clerk.load({ routerPush: to => navigate(to), routerReplace: to => navigate(to), ...options }));
36+
await act(() =>
37+
clerk.load({
38+
standardBrowser: false,
39+
routerPush: to => navigate(to),
40+
routerReplace: to => navigate(to),
41+
...options,
42+
}),
43+
);
3744
view.rerender(wrap(current));
3845

3946
return {

0 commit comments

Comments
 (0)