Repository navigation
chore(mosaic): add code quality and CSS lint rules - #10450
Closed
austincalvelage wants to merge 8 commits into
Closed
austincalvelage wants to merge 8 commits into
austincalvelage wants to merge 8 commits into
Conversation
🦋 Changeset detectedLatest commit: 27d8e6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds ESLint policies scoped to Mosaic, split into rule-specific commits. Reuses the existing TypeScript ESLint and StyleX libraries without adding dependencies, and keeps the current React 18 and React 19 contract and hooks plugin unchanged.
@typescript-eslint/consistent-type-assertions@typescript-eslint/no-unnecessary-conditionutilsandmachinecode.good-css/explicit-transition-propertiestransition: alland shorthand transitions that implicitly target every property. Standalone duration atoms remain valid for style composition.good-css/reduced-motionno-preferenceguard or reduced-motion override that removes the movement or sets its duration to zero.good-css/preserve-focus-outline@stylexjs/valid-styleswithpropLimitsmarginTop,marginBottom,paddingTop, andpaddingBottom, with messages pointing to their logical block-axis equivalents.The new implementation checks exclude tests. The CSS checks inspect authored StyleX declarations in
*.styles.ts, including conditional values, local constant media-query keys, and simple dynamic style functions. They do not inspect arbitrary objects or consumer styles.Only the three transition, reduced-motion, and focus checks remain local. They need StyleX-specific conditional context that the installed library rules do not provide. Accumulator-copying enforcement is omitted because there is no equivalent rule in the existing dependencies.
Replaces the 11 existing physical-spacing declarations with
marginBlockStart,paddingBlockStart, orpaddingBlockEnd. All values stay unchanged, preserving the horizontal layout in both LTR and RTL. Existing assertion exceptions stay under Mosaic's established suppression policy.Checklist
pnpm --filter @clerk/mosaic build:css.Type of change