Repository navigation
test(*): cover agent rules placement, symlink, Edge, and opt-out gaps - #10471
Closed
alexcarpenter wants to merge 1 commit into
Closed
alexcarpenter wants to merge 1 commit into
alexcarpenter wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: fb3e975 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Member
Author
|
Closing; opened too early. Moving this back to local review. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for four gaps in #10320. Each one fails against #10320 as it stands. The fixes belong in #10320. This PR only holds the tests so they can be reviewed together, so CI on this branch is expected to fail until the fixes land.
agentRules.spec.ts). The writer puts the block in the workspace rootAGENTS.md, which points tonode_modules/@clerk/<sdk>/AGENTS.md. pnpm installs the SDK under the app's ownnode_modules(for exampleapps/web/node_modules), not the root, so the pointer does not resolve. Next.js avoids this by writingAGENTS.mdin the app directory. The existing testtargets the workspace root when one existsasserts the current behavior and will need to change with the fix.CLAUDE.mdsymlink (agentRules.spec.ts). WhenCLAUDE.mdlinks to anAGENTS.mdthat does not exist yet, the writer writes the Clerk block, then writes@AGENTS.mdthrough the link and replaces it. The first run leaves only a self-import. The in-memory fs in the spec now models symlinks for this.agent-rules-node.test.ts). On Edge,#safe-node-apisresolves to the browser stub, wherecwdisundefined.nodeCwdOrThrow()throws inside the try and the SDK logs "Could not update AGENTS.md" on a dev middleware run, even though nothing is wrong. The test expects a silent skip. Not reproduced in a running Next.js app.runtimeEnvironment.spec.ts).CLERK_AGENTS_MD=" false"is not trimmed, so the opt-out is ignored.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change