Skip to content

refactor(mosaic): apply review fixes to Waitlist - #10506

Merged
alexcarpenter merged 6 commits into
kylemac/mosaic-waitlist-swingsetfrom
carp/mosaic-waitlist-review-fixes
Oct 28, 2026
Merged

alexcarpenter merged 6 commits into
kylemac/mosaic-waitlist-swingsetfrom
carp/mosaic-waitlist-review-fixes

Conversation

@alexcarpenter

@alexcarpenter alexcarpenter commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Description

Review fixes for #10501, stacked on kylemac/mosaic-waitlist-swingset.

  • Waitlist machine: drops the unused redirected state. After WAITLIST_REDIRECT_DELAY_MS, joined calls onRedirect without leaving the state, and its guard still keeps the timer from firing when there is no redirect. The controller keeps narrowing snapshot.value to WaitlistStep, because Snapshot.value is typed string. A follow-up can switch it to step: snapshot.value once the machine types carry state names.
  • Controller type: removes WaitlistController, which repeated WaitlistViewProps field for field. useWaitlistController now returns WaitlistViewProps, the same way the Switcher derives its controller type from its view props.
  • Email query parameter: the model reads email_address through useMosaicRouter().getSearchParams() (feat(mosaic): add getSearchParams to the Mosaic router hook #10503) instead of window.location.search.
  • Swingset: the live overview and the live Waitlist page read the environment through Mosaic's useMosaicEnvironment() instead of each repeating a clerk as unknown as { __internal_environment } cast.

These are refactors with no user-facing change, so the changeset is empty.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 28, 2026 11:51pm UTC
swingset Ready Ready Preview Oct 28, 2026 11:51pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@changeset-bot

changeset-bot Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6e0ca0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexcarpenter
alexcarpenter merged commit 469562f into kylemac/mosaic-waitlist-swingset Oct 28, 2026
13 checks passed
@alexcarpenter
alexcarpenter deleted the carp/mosaic-waitlist-review-fixes branch October 28, 2026 23:58

This branch was successfully deployed

2 active deployments
Preview – swingset — 6e0ca0cf Deployed Oct 28, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 6e0ca0cf Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant