Repository navigation
refactor(mosaic): apply review fixes to Waitlist - #10506
alexcarpenter merged 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
🦋 Changeset detectedLatest commit: 6e0ca0c The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d4bfbd3 to
dcc002a
Compare
469562f
into
kylemac/mosaic-waitlist-swingset
Description
Review fixes for #10501, stacked on
kylemac/mosaic-waitlist-swingset.redirectedstate. AfterWAITLIST_REDIRECT_DELAY_MS,joinedcallsonRedirectwithout leaving the state, and its guard still keeps the timer from firing when there is no redirect. The controller keeps narrowingsnapshot.valuetoWaitlistStep, becauseSnapshot.valueis typedstring. A follow-up can switch it tostep: snapshot.valueonce the machine types carry state names.WaitlistController, which repeatedWaitlistViewPropsfield for field.useWaitlistControllernow returnsWaitlistViewProps, the same way the Switcher derives its controller type from its view props.email_addressthroughuseMosaicRouter().getSearchParams()(feat(mosaic): add getSearchParams to the Mosaic router hook #10503) instead ofwindow.location.search.useMosaicEnvironment()instead of each repeating aclerk as unknown as { __internal_environment }cast.These are refactors with no user-facing change, so the changeset is empty.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change