Skip to content

test(mosaic): wait for initial focus in phone verification tests - #10557

Merged
austincalvelage merged 1 commit into
mainfrom
austin/fix-user-profile-phone-section-flake
Oct 30, 2026
Merged

austincalvelage merged 1 commit into
mainfrom
austin/fix-user-profile-phone-section-flake

Conversation

@austincalvelage

Copy link
Copy Markdown
Member

Description

Fixes the phone verification test flake seen in Mosaic Feature Tests.

The dialog can assign its initial focus to Close after the test clicks the code field, so subsequent keystrokes miss the input. Both tests that open directly into verification now wait for initial focus before entering the code.

Checklist

  • pnpm test runs as expected. The phone feature suite passes all 31 tests, and the failing case passes 100 repetitions after the fix.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercel Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 30, 2026 8:32pm UTC
swingset Ready Ready Preview Oct 30, 2026 8:32pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Oct 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f69a191

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between a7e5619 and f69a191.

Files selected for processing: 2
  • .changeset/fresh-phones-wait.md
  • packages/mosaic/src/features/user-profile/user-profile-phone-section/__tests__/user-profile-phone-section.feature.test.tsx
Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 6 reviews per hour.

Walkthrough

Two phone verification tests now wait for the dialog’s Close button to receive focus. One wait occurs before entering the verification code. The other occurs after a held verification request is released. The pull request also adds a changeset file with empty YAML frontmatter.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: alexcarpenter

Merge Risk: Minimal · up to f69a1

The focused test waits address the reported focus race, with no remaining merge-blocking risk identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: updating Mosaic phone verification tests to wait for initial focus.
Description check Passed The description directly explains the phone verification test flake, the fix, and the affected tests.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 30, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10557

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10557

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10557

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10557

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10557

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10557

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10557

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10557

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10557

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10557

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10557

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10557

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10557

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10557

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10557

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10557

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10557

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10557

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10557

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10557

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10557

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10557

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10557

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10557

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10557

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10557

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10557

commit: f69a191

@austincalvelage
austincalvelage merged commit 7615c3b into main Oct 30, 2026
56 checks passed
@austincalvelage
austincalvelage deleted the austin/fix-user-profile-phone-section-flake branch October 30, 2026 22:51

This branch was successfully deployed

2 active deployments
Preview – swingset — f69a1913 Deployed Oct 30, 2026 by vercel[bot]
Preview – clerk-js-sandbox — f69a1913 Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants