Skip to content

refactor(mosaic): set card alignment on Card.Root and move the sign-in identifier into the header - #10612

Merged
alexcarpenter merged 3 commits into
kylemac/list-mosaic-sign-in-flowsfrom
carp/mosaic-sign-in-card-align
Nov 3, 2026
Merged

alexcarpenter merged 3 commits into
kylemac/list-mosaic-sign-in-flowsfrom
carp/mosaic-sign-in-card-align

Conversation

@alexcarpenter

@alexcarpenter alexcarpenter commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Description

Stacked on #10339.

  • align moves from Card.Header to Card.Root. Card.Header reads it from CardContext, so <Card.Root align='center'> centers every header in the card, including headers from the reverification steps that sign-in reuses. data-align moves from .cl-card-header to .cl-card-root, and CardHeaderAlign / CardHeaderProps are replaced by CardAlign.
  • The sign-in stories render <Card.Root align='center'>.
  • The password step's identifier and edit button move from Card.Content into a second Card.Description in the header.
  • A centered header now centers with text-align and lets its children take the card's width, and Card.Media centers itself. Content that doesn't wrap, like a long identifier, now truncates inside the card instead of overflowing it.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Nov 3, 2026 6:11pm UTC
swingset Ready Ready Preview Nov 3, 2026 6:11pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 818d7c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@blacksmith-sh

blacksmith-sh Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Matches Password step: identifier in centered header

Before, the title and description sat left-aligned with the identifier in the body below. After, all three are centered in the header, the edit pencil beside the identifier.

Merge-base

Password step before

This PR 818d7c60

Password step after

Also checked · 4 match

Matches Reused reverification step headers center
Matches Edit button in header returns to start
Matches Long identifier truncates inside card
Matches Card.Media centers in centered card

Proof on 818d7c60 (from 2b5ae334) · Did Proof get it right? Yes · No

View full Proof report

@alexcarpenter
alexcarpenter merged commit 8025735 into kylemac/list-mosaic-sign-in-flows Nov 3, 2026
13 checks passed
@alexcarpenter
alexcarpenter deleted the carp/mosaic-sign-in-card-align branch November 3, 2026 19:25

This branch was successfully deployed

2 active deployments
Preview – swingset — 818d7c60 Deployed Nov 3, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 818d7c60 Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants