fix(repo): publish handed-off evidence with gh issue edit by mikepitre · Pull Request #10645 · clerk/javascript

mikepitre · 2026-11-04T14:29:39Z

Description

verify-attach publishes the evidence a cloud session hands off. It ran gh pr edit, which reads the pull request's review requests, and the evidence token can't read a requested team. Once team-mobile was requested on clerk/javascript#10643, the run failed with GraphQL: Resource not accessible by personal access token (repository.pullRequest.reviewRequests.nodes.0.requestedReviewer), and #10643 got no evidence block.

This switches the two description writes in scripts/verify-attach.mjs to gh issue edit, which writes the same description without reading the review requests. It's the change clerk/clerk-ios#772 made, and clerk-android has the same code. The tests come over from clerk-ios too, including the one where gh pr edit fails on a requested team and the publish still succeeds. references/remote.md and the workflow's step name now say gh issue edit.

npx vitest run scripts/verify-attach.test.mjs: 199 pass. The script now matches clerk-ios line for line.

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

🤖 Generated with Claude Code

gh pr edit reads the pull request's review requests, and the evidence token cannot read a requested team, so verify-attach failed with "Resource not accessible by personal access token" once team-mobile was requested (#10643). gh issue edit writes the same description without reading them. This is the change clerk/clerk-ios#772 made. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

vercel · 2026-11-04T14:29:44Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
clerk-js-sandbox	Ready	Preview	Nov 4, 2026 2:31pm UTC
swingset	Ready	Preview	Nov 4, 2026 2:31pm UTC

changeset-bot · 2026-11-04T14:29:48Z

🦋 Changeset detected

Latest commit: 950bc9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-11-04T14:29:56Z

No actionable comments were generated in the recent review.

Walkthrough

The verification publisher now uses gh issue edit instead of gh pr edit to update pull request bodies and attach evidence. The workflow label, documentation, error messages, and publishing tests reflect this change. A test covers the case where gh pr edit fails because the evidence token cannot read a requested team reviewer.

Estimated code review effort: 2 (Simple) | ~10 minutes

Severity of issue fixed: Medium

Possibly related PRs

clerk/javascript#10643: Its requested team exposed the gh pr edit permission failure addressed by this command change.
clerk/javascript#10620: It changes the Expo verification flow that creates a draft pull request and attaches evidence.
clerk/javascript#10622: It changes the remote verification flow that waits for evidence in the pull request body.

Suggested reviewers: wobsoriano

Merge Risk: Minimal · up to 950bc

No concrete current-head merge-blocking risk is established; evidence publishing uses the supported issue-edit path.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly identifies the main change: publishing handed-off evidence with `gh issue edit`.
Description check		The description explains the permission failure, the switch from `gh pr edit` to `gh issue edit`, the affected files, and the test results.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 2 files. (3 skipped: 3 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

Recent review info

Run configuration

Source mode: Auto

Repository: clerk/javascript

Branch: main

File: .coderabbit.yaml

Commit: f0cc0ed

Layers: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: `6131356c-b725-439e-ba4b-313cc1e7d808`

Commits

Reviewing files that changed from the base of the PR and between `f0cc0ed` and `950bc9a`.

Files selected for processing: 5

`.changeset/verify-attach-issue-edit.md`

`.claude/skills/verify-clerk-expo/references/remote.md`

`.github/workflows/verify-attach.yml`

`scripts/verify-attach.mjs`

`scripts/verify-attach.test.mjs`

Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

`clerk/clerk_go` (manual)

`clerk/dashboard` (manual)

`clerk/accounts` (manual)

`clerk/backoffice` (manual)

`clerk/clerk` (manual)

`clerk/clerk-docs` (manual)

`clerk/cloudflare-workers` (manual)

`clerk/internal-mobile-e2e` (auto-detected)

`clerk/clerk-ios` (auto-detected)

`clerk/clerk-android` (auto-detected)

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.

pkg-pr-new · 2026-11-04T14:32:13Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10645

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10645

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10645

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10645

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10645

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10645

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10645

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10645

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10645

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10645

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10645

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10645

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10645

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10645

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10645

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10645

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10645

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10645

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10645

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10645

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10645

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10645

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10645

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10645

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10645

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10645

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10645

commit: 950bc9a

blacksmith-sh · 2026-11-04T14:34:47Z

Publish succeeds with a team review request

With a team requested, before stops on gh pr edit's review-request error and writes nothing; after publishes the evidence block via gh issue edit, never asking for review requests.

_Merge-base

_{This PR 950bc9ab}

Also checked · 1 match

Same description without a team request

_{Proof on 950bc9ab · Did Proof get it right? Yes · No}

View full Proof report

wobsoriano

🧪

vercel Bot deployed to Preview – clerk-js-sandbox November 4, 2026 14:30

View deployment

github-actions Bot added the actions label Nov 4, 2026

mikepitre requested a review from a team November 4, 2026 14:30

vercel Bot deployed to Preview – swingset November 4, 2026 14:31

View deployment

wobsoriano approved these changes Nov 4, 2026

View reviewed changes

mikepitre merged commit ce908a4 into main Nov 4, 2026
57 checks passed

mikepitre deleted the verify-attach-issue-edit branch November 4, 2026 14:43

Navigation Menu

Repository navigation

fix(repo): publish handed-off evidence with gh issue edit - #10645

fix(repo): publish handed-off evidence with gh issue edit#10645
mikepitre merged 1 commit into
mainfrom
verify-attach-issue-edit

mikepitre commented Nov 4, 2026

Uh oh!

vercel Bot commented Nov 4, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Nov 4, 2026

Uh oh!

coderabbitai Bot commented Nov 4, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Nov 4, 2026

Uh oh!

blacksmith-sh Bot commented Nov 4, 2026 •

edited

Loading

Uh oh!

wobsoriano left a comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mikepitre commented Nov 4, 2026

Description

Checklist

Type of change

Uh oh!

vercel Bot commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Nov 4, 2026

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Nov 4, 2026

Uh oh!

blacksmith-sh Bot commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Publish succeeds with a team review request

Uh oh!

wobsoriano left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented Nov 4, 2026 •

edited

Loading

coderabbitai Bot commented Nov 4, 2026 •

edited

Loading

blacksmith-sh Bot commented Nov 4, 2026 •

edited

Loading