You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(testing): wait for the API keys expiration dropdown instead of force-clicking - #10647
api keys component @machine › can create api keys flakes. In CI logs, the "Create key" click times out because an open expiration option list covers it (cl-selectOption__apiKeyExpiration … intercepts pointer events, jobs 126228362574 and 126335179987).
selectExpiration force-clicks the option text. force: true was added in #6999, the same commit that added an absolutely positioned ::before to each option. A force click skips Playwright's stability check, so it can fire while the list is still animating open. When it misses, nothing is selected and the list stays open.
selectExpiration now:
clicks the trigger by its stable class (.cl-selectButton__apiKeyExpiration), since its "Select date" label changes once a value is chosen
waits for aria-expanded="true"
clicks the option by role, without force
waits for aria-expanded="false"
The list not closing now fails at the step where it happens, instead of as a timeout on a later click.
Checklist
pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
Reviewing files that changed from the base of the PR and between e7580d7 and f5f980e.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
selectExpiration now opens the expiration dropdown, checks that it is expanded, selects the exact matching option (defaulting to never), and checks that it is collapsed. A patch changeset records this update.
The change is mergeable with no identified actionable risk.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title names the main change: selectExpiration in the API keys page object now waits for the expiration dropdown to open and close instead of force-clicking an option. It also names the area (testi…
Description check
The description states the flaky test, the CI error (an open expiration option list intercepts pointer events), and the cause (force-clicking option text skips the stability check). It then lists the …
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: selectExpiration in the API keys page object now waits for the expiration dropdown to open and close instead of force-clicking an option. It also names the area (testing package) and the fix type. The title is specific and matches the changeset, so it passes.
Full details: Description check
Explanation
The description states the flaky test, the CI error (an open expiration option list intercepts pointer events), and the cause (force-clicking option text skips the stability check). It then lists the new steps in selectExpiration: click by stable class, wait for aria-expanded true, click by role without force, and wait for aria-expanded false. These match the changes in apiKeys.ts and the changeset, so the description passes.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
api keys component @machine › can create api keysflakes. In CI logs, the "Create key" click times out because an open expiration option list covers it (cl-selectOption__apiKeyExpiration … intercepts pointer events, jobs 126228362574 and 126335179987).selectExpirationforce-clicks the option text.force: truewas added in #6999, the same commit that added an absolutely positioned::beforeto each option. A force click skips Playwright's stability check, so it can fire while the list is still animating open. When it misses, nothing is selected and the list stays open.selectExpirationnow:.cl-selectButton__apiKeyExpiration), since its "Select date" label changes once a value is chosenaria-expanded="true"forcearia-expanded="false"The list not closing now fails at the step where it happens, instead of as a timeout on a later click.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change