Skip to content

fix(testing): wait for the API keys expiration dropdown instead of force-clicking #10647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcarpenter merged 2 commits into from
Nov 4, 2026
Merged

fix(testing): wait for the API keys expiration dropdown instead of force-clicking #10647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7580d7
fix(testing): wait for the API keys expiration dropdown instead of fo…
alexcarpenter Nov 4, 2026
f5f980e
Merge branch 'main' into carp/api-keys-select-flake
alexcarpenter Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/api-keys-select-expiration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/testing': patch
---

Make the unstable API keys page object's `selectExpiration` wait for the expiration dropdown to open and close, instead of force-clicking the option while the list is still animating.
9 changes: 7 additions & 2 deletions packages/testing/src/playwright/unstable/page-objects/apiKeys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { expect } from '@playwright/test';

import type { EnhancedPage } from './app';
import { common } from './common';

Expand Down Expand Up @@ -51,8 +53,11 @@ export const createAPIKeysComponentPageObject = (testArgs: { page: EnhancedPage
return page.getByLabel(/Description/i).fill(value);
},
selectExpiration: async (value?: keyof typeof expirationOptions) => {
await page.getByRole('button', { name: /Select date/i }).click();
return page.getByText(expirationOptions[value ?? 'never'], { exact: true }).click({ force: true });
const trigger = page.locator('.cl-selectButton__apiKeyExpiration');
await trigger.click();
await expect(trigger).toHaveAttribute('aria-expanded', 'true');
await page.getByRole('option', { name: expirationOptions[value ?? 'never'], exact: true }).click();
await expect(trigger).toHaveAttribute('aria-expanded', 'false');
},
clickSaveButton: () => {
return page.getByText(/Create key/i).click();
Expand Down
Loading