You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(mosaic): keep combobox hover across the gap between options - #10760
Combobox options had a 2px dead strip between them: with the pointer there, no option was highlighted. Each option now gets the same ::before hit-area bleed that Menu items use, so the gap belongs to the neighbouring option.
Before
After
Pointer in the gap between Apple and Apricot
Checklist
pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
Combobox options now use relative positioning and an empty, absolutely positioned ::before pseudo-element. Its insets extend by space['0.5']. The existing option height remains unchanged. The changeset file gains two horizontal-rule markers.
clerk/javascript#10688: Changes Combobox option spacing and height in the same style file.
clerk/javascript#10689: Changes Combobox option spacing and height in the same style file.
Suggested reviewers:prestonwebdev
Merge Risk: Minimal · up to 79603
This is a small styling fix that removes the dead strip between combobox options on hover. No concrete behavioral, security or data risk was found. Whether the fix needs a release note or a browser test is a judgment call for the maintainers.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly identifies the combobox hover fix across the gap between options.
Description check
The description explains the 2px dead strip and the hit-area change that addresses it.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.
The reason will be displayed to describe this comment to others. Learn more.
Additional comments: 2
.changeset/mosaic-combobox-gap.md-1-2: 1
1-2: Major · Functional Correctness · Quick win
Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.
Add a Mosaic patch changeset.
This user-facing fix has no package entry. Without another changeset, it will not trigger a Mosaic release. It will also be absent from the changelog. Add @clerk/mosaic: patch and describe the hover fix.
As per coding guidelines, “If a change has no user-facing impact, use an empty changeset.”
109-114: Major · Maintainability & Code Quality · Quick win
Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.
Add a browser test for the gap.
The existing combobox test hovers an option, but does not test the gap. (raw.githubusercontent.com) Add a browser test that moves the pointer through the gap and checks the highlighted option.
As per coding guidelines, “Unit tests are required for all new functionality,” and layout tests must run in a browser.
Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Description
Combobox options had a 2px dead strip between them: with the pointer there, no option was highlighted. Each option now gets the same
::beforehit-area bleed that Menu items use, so the gap belongs to the neighbouring option.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change