You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(mosaic): add combobox option parts and center phone input countries - #10764
Adds Combobox.Media, Combobox.Label and Combobox.Detail for composing an option, and builds PhoneInput's country options from them.
Fixes the country name sitting off center in its row. A fixed 24px height on the name pushed its text 2.5px above the row's center. It's now within 0.5px, the same as the calling code.
The flag, name and code now carry .cl-combobox-option-media, .cl-combobox-option-label and .cl-combobox-option-detail. Before, they were bare spans with only StyleX atoms.
Class names follow Select's <row>-<part> scheme (select-option-media). Menu's menu-media/menu-label are renamed separately in a follow-up PR.
The Swingset Combobox page gets an OptionParts story and rows for the new parts.
Checklist
pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
Verified in swingset from evidence 20261111T000434Z-phone-country-options, captured at 402661992ce0 with uncommitted changes; before 20261111T000507Z-phone-country-options-control, captured at 402661992ce0. Attached at pull request head ece98f1bfcd1.
No actionable comments were generated in the recent review.
Walkthrough
Combobox adds Media, Label, and Detail components for composing option content, with styles, public exports, tests, and Storybook documentation. PhoneInput now uses these parts to display country flags, names, and calling codes. Its related option styles and tests are updated.
The change adds option parts and uses them in the phone country picker. No merge-blocking risk was established.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly summarizes the new combobox option parts and their use in PhoneInput country options.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description explains the new Combobox option parts, their use in PhoneInput, and the related styling and documentation changes.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 9 files. (2 skipped: 2 unsupported.)
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
Combobox.Media,Combobox.LabelandCombobox.Detailfor composing an option, and buildsPhoneInput's country options from them..cl-combobox-option-media,.cl-combobox-option-labeland.cl-combobox-option-detail. Before, they were bare spans with only StyleX atoms.<row>-<part>scheme (select-option-media). Menu'smenu-media/menu-labelare renamed separately in a follow-up PR.OptionPartsstory and rows for the new parts.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Verified in swingset from evidence
20261111T000434Z-phone-country-options, captured at402661992ce0with uncommitted changes; before20261111T000507Z-phone-country-options-control, captured at402661992ce0. Attached at pull request headece98f1bfcd1.