Repository navigation
fix(linkTools.Vertices): type interactiveLinkNode - #3549
Merged
kumilingus merged 1 commit intoOct 14, 2026
Merged
kumilingus merged 1 commit into
kumilingus merged 1 commit into
Conversation
The vertexAdding option was typed as interactiveLineNode, but the tool reads interactiveLinkNode. TypeScript rejected the working name, and the name it accepted had no effect at runtime. Code that still passes interactiveLineNode now fails to compile. That name never did anything, so no alias is kept.
MartinKanera
marked this pull request as ready for review
October 14, 2026 07:54
kumilingus
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linkTools.VerticesreadsvertexAdding.interactiveLinkNode, but the typings declared the property asinteractiveLineNode. TypeScript users who wrote the working name got a compile error, and the name that compiled did nothing at runtime. With this change the typings use the name the tool reads.Changes
linkTools.Vertices.VertexAddingOptions:interactiveLineNoderenamed tointeractiveLinkNode.test/tscheck that passesvertexAdding: { interactiveLinkNode: 'wrapper' }.patchchangeset for@joint/core.Breaking changes
interactiveLineNodenow fails to compile (TS2561). That name never had any effect at runtime, so the error points at an existing bug; no alias is kept.Verification
yarn workspace @joint/core lint: passyarn workspace @joint/core test: pass (mocha server 4/4, Karma joint 2157/2157, geometry 350/350, vectorizer 453/453 with coverage thresholds, qunit,ts:test,ts:test-exports)test/tscheck failed with TS2561 before the rename and passes after it.yarn changeset status --since=upstream/master:@joint/corepatchRelated