convert the eval tests into compile time tests that check for warnings about undeclared vars

Author: swannodette

src/test/cljs/cljs/destructuring_test.cljs

@@ -254,13 +254,7 @@
         (is (thrown? js/Error (let [{:keys! [b & :foo/c]} (dissoc sample-map :foo/c)] b)))
         (is (= 1 (let [{:foo/keys! [aa & :bb]} sample-map2] aa)))
         (is (= aa 1))
-        (is (= 1 (let [{:keys! [::a & ::b]} {::a 1 , ::b 2}] a)))))
-    #_(testing "that right of & is unbound (compile-time errors)"
-      (is (thrown? js/Error (eval '(let [{:keys! [a & :b]} sample-map] b))))
-      (is (thrown? js/Error (eval '(let [{a :a {aa :a :as m :keys [b c & :e]} :b} sample-map] e))))
-      (is (thrown? js/Error (eval '(let [{:keys! [foo/a & :foo/c]} sample-map] c))))
-      (let [sample-map2 {:foo/aa 1 :bb 2 :foo/cc 3}]
-        (is (thrown? js/Error (eval '(let [{:foo/keys! [foo/aa & :foo/cc]} sample-map2] cc))))))))
+        (is (= 1 (let [{:keys! [::a & ::b]} {::a 1 , ::b 2}] a)))))))
 
 (deftest syms-bang
   (let [sample-map '{a 1 b 2}]
@@ -291,13 +285,7 @@
         (is (thrown? js/Error (let [{:syms! [b & 'foo/c]} (dissoc sample-map 'b)] b)))
         (is (thrown? js/Error (let [{:syms! [b & 'foo/c]} (dissoc sample-map 'foo/c)] b)))
         (is (= aa 1))
-        (is (= 1 (let [{:foo/syms! [aa & 'bb]} sample-map2] aa)))))
-    #_(testing "that right of & is unbound (compile-time errors)"
-      (is (thrown? js/Error (eval '(let [{:syms! [a & 'b]} sample-map] b))))
-      (is (thrown? js/Error (eval '(let [{a a {aa a :as m :syms [b c & 'e]} :b} sample-map] e))))
-      (is (thrown? js/Error (eval '(let [{:syms! [foo/a & 'foo/c]} sample-map] c))))
-      (let [sample-map2 '{foo/aa 1 bb 2 foo/cc 3}]
-        (is (thrown? js/Error (eval '(let [{:foo/syms! [foo/aa & 'foo/cc]} sample-map2] cc))))))))
+        (is (= 1 (let [{:foo/syms! [aa & 'bb]} sample-map2] aa)))))))
 
 (deftest strs-bang
   (let [sample-map {"a" 1 "b" 2}]
@@ -316,10 +304,7 @@
         (is (= b 3))
         (is (= c 4))
         (is (thrown? js/Error (let [{a "a" {aa "a" :as m :strs! [b c & "d" "e"]} "b"} sample-map] a)))
-        (is (thrown? js/Error (let [{a "a" {aa "a" :as m :strs! [b c & "d"]} "b"} (update sample-map "b" dissoc "c")] a)))))
-    #_(testing "that right of & is unbound (compile-time errors)"
-      (is (thrown? js/Error (eval '(let [{:strs! [a & "b"]} sample-map] b))))
-      (is (thrown? js/Error (eval '(let [{a "a" {aa "a" :as m :keys [b c & "e"]} "b"} sample-map] e)))))))
+        (is (thrown? js/Error (let [{a "a" {aa "a" :as m :strs! [b c & "d"]} "b"} (update sample-map "b" dissoc "c")] a)))))))
 
 (deftest select-directive
   (let [m {:a 1 :b 2 :c 3 :d 4
@@ -397,7 +382,7 @@
     (testing "happy path"
       (testing ":defaults"
         (is (empty? (let [{:defaults d :or {}} {}] d)))
-        #_(is (thrown? js/Error (eval '(let [{:defaults d :or {:a 1}} {}] d))))
+        
         (is (= {:a 1} (let [{:keys [a] :defaults d :or {:a 1}} {}] d)))
         (is (= {:a 1} (let [{:keys [a] :defaults d :or {a 1}} {}] d)))
         (is (= {:a 1, 'b 2, "c" 3} (let [{b 'b, c "c", :keys [a] :defaults d :or {:a 1, 'b 2, "c" 3}} {}] d))))
@@ -437,11 +422,7 @@
 
       (testing "mixed things after &"
         (is (= 1 (let [{:keys [a & 'b]} {:a 1}] a)))
-        (is (= 1 (let [{:keys! [a & 'b "c"]} {:a 1, 'b 2, "c" 3}] a))))
-
-      #_(testing "known compile-time errors"
-        (is (thrown? js/Error (eval '(let [{:keys [a] :defaults d :or {:a 1, a 1}} {}] d))))
-        (is (thrown? js/Error (eval '(let [{:defaults d} {}] d))))))))
+        (is (= 1 (let [{:keys! [a & 'b "c"]} {:a 1, 'b 2, "c" 3}] a)))))))
 
 (comment
 

src/test/clojure/cljs/compiler_tests.clj

@@ -44,20 +44,27 @@
        (doseq [form forms]
          (comp/emit (ana/analyze (ana/empty-env) form)))))))
 
+(defn compile-simple-form
+  [form]
+  (env/with-compiler-env (env/default-compiler-env)
+    (comp/with-core-cljs {}
+      (fn []
+        (compile-form-seq [form])))))
+
 #_(deftest should-recompile
-  (let [src (File. "test/hello.cljs")
-        dst (File/createTempFile "compilertest" ".cljs")
-        opt {:optimize-constants true}
-        optmod {:optimize-constants true :elide-asserts false}]
-    (with-redefs [util/*clojurescript-version* {:major 0 :minor 0 :qualifier 42}]
-      (env/with-compiler-env (env/default-compiler-env)
-        (.setLastModified dst (- (.lastModified src) 100))
-        (is (comp/requires-compilation? src dst opt))
-        (comp/compile-file src dst opt)
-        (is (not (comp/requires-compilation? src dst opt)))
-        (is (comp/requires-compilation? src dst optmod))
-        (comp/compile-file src dst optmod)
-        (is (not (comp/requires-compilation? src dst optmod)))))))
+    (let [src (File. "test/hello.cljs")
+          dst (File/createTempFile "compilertest" ".cljs")
+          opt {:optimize-constants true}
+          optmod {:optimize-constants true :elide-asserts false}]
+      (with-redefs [util/*clojurescript-version* {:major 0 :minor 0 :qualifier 42}]
+        (env/with-compiler-env (env/default-compiler-env)
+          (.setLastModified dst (- (.lastModified src) 100))
+          (is (comp/requires-compilation? src dst opt))
+          (comp/compile-file src dst opt)
+          (is (not (comp/requires-compilation? src dst opt)))
+          (is (comp/requires-compilation? src dst optmod))
+          (comp/compile-file src dst optmod)
+          (is (not (comp/requires-compilation? src dst optmod)))))))
 
 (deftest fn-scope-munge
   (is (= (comp/munge
@@ -425,6 +432,44 @@
         (is (instance? clojure.lang.ExceptionInfo t))
         (is (.startsWith (-> t ex-cause ex-message) "Can't use & as a local binding"))))))
 
+;; -----------------------------------------------------------------------------
+;; 1.13 Compile Time Destructuring Tests
+
+;; The following only emits warnings in ClojureScript
+ 
+(defn undeclared-warning? [form sym]
+  (let [[[warn-type warn-mesg] :as warns] (capture-warnings (compile-simple-form form))]
+    (and (= warn-type :undeclared-var)
+      (.startsWith warn-mesg  (str "WARNING: Use of undeclared Var cljs.user/" (name sym))))))
+
+(deftest keys-bang
+  (testing "that right of & is unbound (compile-time errors)"
+    (is (undeclared-warning? '(let [{:keys! [a & :b]} {:a 1 :b 2}] b) 'b))
+    (is (undeclared-warning? '(let [{a :a {aa :a :as m :keys [b c & :e]} :b} {:a 1 :b 2}] e) 'e))
+    (is (undeclared-warning? '(let [{:keys! [foo/a & :foo/c]} {:a 1 :b 2}] c) 'c))
+    (is (undeclared-warning? '(let [{:foo/keys! [foo/aa & :foo/cc]} {:foo/aa 1 :bb 2 :foo/cc 3}] cc) 'cc))))
+
+(deftest syms-bang
+  (testing "that right of & is unbound (compile-time errors)"
+    (is (undeclared-warning? '(let [{:syms! [a & 'b]} (quote {a 1 b 2})] b) 'b))
+    #_(is (undeclared-warning? '(let [{a a {aa a :as m :syms [b c & 'e]} :b} (quote {a 1 b 2})] e) 'e))
+    (is (undeclared-warning? '(let [{:syms! [foo/a & 'foo/c]} (quote {a 1 b 2})] c) 'c))
+    (is (undeclared-warning? '(let [{:foo/syms! [foo/aa & 'foo/cc]} (quote {foo/aa 1 bb 2 foo/cc 3})] cc) 'cc))))
+
+(deftest strs-bang
+  (testing "that right of & is unbound (compile-time errors)"
+    (is (undeclared-warning? '(let [{:strs! [a & "b"]} {"a" 1 "b" 2}] b) 'b))
+    (is (undeclared-warning? '(let [{a "a" {aa "a" :as m :keys [b c & "e"]} "b"} {"a" 1 "b" 2}] e) 'e))))
+
+(deftest select-or-defaults
+  (testing ":defaults"
+    (is (thrown? Exception
+          (compile-simple-form
+            '(let [{:defaults d :or {:a 1}} {}] d)))))
+  (testing "known compile-time errors"
+    (is (thrown? Exception (compile-simple-form '(let [{:keys [a] :defaults d :or {:a 1, a 1}} {}] d))))
+    (is (thrown? Exception (compile-simple-form '(let [{:defaults d} {}] d))))))
+
 ;; CLJS-1225
 
 (comment