Skip to content

Commit 51ffda7

Browse files
committed
fix(ci): zig fmt repair (root_set.zig stray blank line) + fmt-check joins the local smoke core
Four 2026-07-02 main pushes went red in CI on ci_gate.sh's step (1/2) `zig fmt --check src/` — a single stray blank line in root_set.zig that no LOCAL tier checked (zlinter != fmt). The check now runs in the smoke core (portable, <1s) so formatting fails at commit time, not 15 minutes later in CI. Smell-audited: 1: gate-parity fix — the local tiers now cover everything CI's early steps check
1 parent 3bc1ba8 commit 51ffda7

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

‎src/runtime/gc/root_set.zig‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ pub const RootSource = enum {
8686
/// D-430 analysis-roots frame: it never gained a production writer, and the
8787
/// frame subsumes its declared purpose — `expandIfMacro` now pushes the
8888
/// macro-expansion intermediates + result into the current AnalysisFrame.)
89-
9089
/// One operand-stack-resident root scope, published on the thread's
9190
/// eval-frame chain so a GC `collect()` walks live operand Values
9291
/// (`stack[0..sp]`) + slot Values (`locals`) — ADR-0091. Two kinds of

‎test/run_all.sh‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ E2E_JOBS="${E2E_JOBS:-8}"
4949
# how many smoke-only commits ride before a full gate is forced.
5050
SMOKE_MODE=0
5151
SMOKE_E2E=""
52-
SMOKE_CORE="zig_build_test_vm,zig_build_test_tree_walk,zlinter,build_cljw,lazy_ns_replay,corpus_regression"
52+
SMOKE_CORE="zig_fmt_check,zig_build_test_vm,zig_build_test_tree_walk,zlinter,build_cljw,lazy_ns_replay,corpus_regression"
5353

5454
while [[ $# -gt 0 ]]; do
5555
case "$1" in
@@ -345,6 +345,11 @@ run_step "debt_id_refs" "bash scripts/check_debt_id_refs.sh --gate"
345345
# cannot drift or accept-without-reason. Rule: accepted_divergences.md.
346346
run_step "accepted_divergences" "bash scripts/check_accepted_divergences.sh --gate"
347347

348+
# Formatting gate — mirrors CI's ci_gate.sh step (1/2) so a non-canonical
349+
# file fails LOCALLY at smoke time, not 15 minutes later in CI (2026-07-02:
350+
# four pushes went red on a single stray blank line only CI checked).
351+
run_step "zig_fmt_check" "zig fmt --check src/"
352+
348353
# zlinter no_deprecated gate (ADR-0003) — Mac-host only. zlinter is
349354
# fetched via `zig fetch` against GitHub; OrbStack runs are network-
350355
# free per .dev/orbstack_setup.md.

0 commit comments

Comments
 (0)