Merge remote-tracking branch 'origin/main' into symphony/pln-202

Author: aponamarev

install.sh

@@ -10,6 +10,17 @@
 #   3. Installs all 6 plugins globally (user scope)
 #   4. Auto-update is enabled by default — plugins stay current automatically
 #
+# NOTE: The BASH_VERSION check below can be bypassed by setting the BASH_VERSION
+# env var before invoking under sh/dash (e.g. BASH_VERSION=x sh install.sh).
+# This is a known limitation: the guard is a best-effort hint, not a security boundary.
+if [ -z "${BASH_VERSION:-}" ]; then
+  printf 'Error: This script requires bash. Run: bash install.sh\n  or: curl -fsSL https://raw.githubusercontent.com/closedloop-ai/claude-plugins/main/install.sh | bash\n' >&2
+  exit 1
+fi
+if [[ "${BASH_VERSINFO[0]:-0}" -lt 3 || ("${BASH_VERSINFO[0]:-0}" -eq 3 && "${BASH_VERSINFO[1]:-0}" -lt 2) ]]; then
+  printf 'Error: Bash 3.2+ required (found %s)\n' "$BASH_VERSION" >&2
+  exit 1
+fi
 set -euo pipefail
 
 # ── Colors ───────────────────────────────────────────────────────────────────
@@ -24,12 +35,26 @@ info()  { echo -e "${GREEN}[✓]${NC} $1"; }
 warn()  { echo -e "${YELLOW}[!]${NC} $1"; }
 err()   { echo -e "${RED}[✗]${NC} $1"; }
 step()  { echo -e "${BLUE}[→]${NC} ${BOLD}$1${NC}"; }
+snapshot_version() { grep -m1 "^$2 " "$1" 2>/dev/null | awk '{print $2}' || true; }
+sanitize_stderr()  {
+    # Strip ANSI color escapes, then drop non-printable control chars.
+    # Uses bash ANSI-C quoting for a literal ESC so this works under BSD sed (macOS)
+    # as well as GNU sed. `tr` with octal ranges is POSIX-portable across both.
+    local esc=$'\033'
+    sed "s/${esc}\[[0-9;]*[a-zA-Z]//g" "$1" | tr -d '\000-\010\013-\037\177' >&2
+}
 
 # ── Constants ────────────────────────────────────────────────────────────────
 MARKETPLACE_SOURCE="closedloop-ai/claude-plugins"
 MARKETPLACE_NAME="closedloop-ai"
 PLUGINS=(bootstrap code code-review judges platform self-learning)
 
+# ── Per-run working directory ────────────────────────────────────────────────
+WORK_DIR=$(mktemp -d "${TMPDIR:-/tmp}/closedloop-install.XXXXXX")
+chmod 700 "$WORK_DIR"
+_cleanup() { rm -rf "$WORK_DIR"; }
+trap _cleanup EXIT
+
 # ── Preflight checks ────────────────────────────────────────────────────────
 echo
 echo -e "${BOLD}ClosedLoop Claude Plugins Installer${NC}"
@@ -49,8 +74,8 @@ info "Claude Code CLI found: $(claude --version 2>/dev/null || echo 'unknown ver
 # Python 3.11+
 if command -v python3 &>/dev/null; then
     PY_VERSION=$(python3 -c 'import sys; print(f"{sys.version_info.major}.{sys.version_info.minor}")')
-    PY_MAJOR=$(echo "$PY_VERSION" | cut -d. -f1)
-    PY_MINOR=$(echo "$PY_VERSION" | cut -d. -f2)
+    PY_MAJOR="${PY_VERSION%%.*}"
+    PY_MINOR="${PY_VERSION##*.}"
     if [[ "$PY_MAJOR" -gt 3 || ( "$PY_MAJOR" -eq 3 && "$PY_MINOR" -ge 11 ) ]]; then
         info "Python $PY_VERSION"
     else
@@ -61,23 +86,32 @@ else
 fi
 
 # jq
-if command -v jq &>/dev/null; then
-    info "jq found"
+if ! command -v jq &>/dev/null; then
+    err "jq is required but not found."
+    echo "    Install: brew install jq  (macOS)"
+    echo "    Install: apt install jq   (Debian/Ubuntu)"
+    exit 1
 else
-    warn "jq not found — some plugin features require it"
-    echo "    Install: brew install jq (macOS) / apt install jq (Linux)"
+    info "jq found"
 fi
 
 echo
 
 # ── Add marketplace ─────────────────────────────────────────────────────────
 step "Registering closedloop-ai marketplace..."
 
-if claude plugin marketplace add "$MARKETPLACE_SOURCE" 2>/dev/null; then
-    info "Marketplace registered: $MARKETPLACE_SOURCE"
+_MARKETPLACE_LIST=$(claude plugin marketplace list --json 2>/dev/null)
+if [[ -n "$_MARKETPLACE_LIST" ]] \
+   && echo "$_MARKETPLACE_LIST" | jq -e --arg name "$MARKETPLACE_NAME" 'any(.name == $name)' &>/dev/null; then
+    info "Marketplace already registered: $MARKETPLACE_NAME"
 else
-    # May already be registered — not a fatal error
-    warn "Marketplace may already be registered (continuing)"
+    [[ -z "$_MARKETPLACE_LIST" ]] && warn "Could not query marketplace list — attempting add anyway"
+    if claude plugin marketplace add "$MARKETPLACE_SOURCE" 2>"$WORK_DIR/marketplace_err"; then
+        info "Marketplace registered: $MARKETPLACE_SOURCE"
+    else
+        warn "Marketplace add failed:"
+        sanitize_stderr "$WORK_DIR/marketplace_err"
+    fi
 fi
 
 echo
@@ -86,33 +120,62 @@ echo
 step "Installing plugins (user scope)..."
 
 INSTALLED=0
+UPDATED=0
+UP_TO_DATE=0
 FAILED=0
 
+SNAPSHOT_PRE="$WORK_DIR/snapshot_pre"
+SNAPSHOT_POST="$WORK_DIR/snapshot_post"
+STDERR_FILE="$WORK_DIR/install_err"
+
+claude plugin list --json 2>/dev/null \
+  | jq -r '.[] | .id + " " + .version' > "$SNAPSHOT_PRE" 2>/dev/null || true
+[[ -s "$SNAPSHOT_PRE" ]] || warn "Could not snapshot installed plugins — state detection will be approximate"
+
+SUCCESSFUL_PLUGINS=()
+
 for plugin in "${PLUGINS[@]}"; do
-    PLUGIN_REF="${plugin}@${MARKETPLACE_NAME}"
-    if claude plugin install "$PLUGIN_REF" --scope user 2>/dev/null; then
-        info "Installed: $plugin"
+    plugin_ref="${plugin}@${MARKETPLACE_NAME}"
+    if claude plugin install "$plugin_ref" --scope user 2>"$STDERR_FILE"; then
+        SUCCESSFUL_PLUGINS+=("$plugin_ref")
+    # Install failed — may already exist; try update instead
+    elif claude plugin update "$plugin_ref" --scope user 2>"$STDERR_FILE"; then
+        SUCCESSFUL_PLUGINS+=("$plugin_ref")
+    else
+        [[ -s "$STDERR_FILE" ]] && sanitize_stderr "$STDERR_FILE"
+        warn "Could not install/update: $plugin"
+        FAILED=$((FAILED + 1))
+    fi
+done
+
+claude plugin list --json 2>/dev/null \
+  | jq -r '.[] | .id + " " + .version' > "$SNAPSHOT_POST" 2>/dev/null || true
+
+for plugin_ref in "${SUCCESSFUL_PLUGINS[@]+"${SUCCESSFUL_PLUGINS[@]}"}"; do
+    plugin="${plugin_ref%@*}"
+    pre_ver=$(snapshot_version "$SNAPSHOT_PRE" "$plugin_ref")
+    post_ver=$(snapshot_version "$SNAPSHOT_POST" "$plugin_ref")
+    if [[ -z "$pre_ver" || -z "$post_ver" ]]; then
         INSTALLED=$((INSTALLED + 1))
+        info "Installed: $plugin"
+    elif [[ "$pre_ver" == "$post_ver" ]]; then
+        UP_TO_DATE=$((UP_TO_DATE + 1))
+        info "Already up to date: $plugin"
     else
-        # May already be installed — try to update instead
-        if claude plugin update "$PLUGIN_REF" --scope user 2>/dev/null; then
-            info "Updated: $plugin"
-            INSTALLED=$((INSTALLED + 1))
-        else
-            warn "Could not install/update: $plugin"
-            FAILED=$((FAILED + 1))
-        fi
+        UPDATED=$((UPDATED + 1))
+        info "Updated: $plugin ($pre_ver -> $post_ver)"
     fi
 done
 
 echo
 
 # ── Summary ──────────────────────────────────────────────────────────────────
+TOTAL=$((INSTALLED + UPDATED + UP_TO_DATE + FAILED))
 echo "────────────────────────────────────"
 if [[ $FAILED -eq 0 ]]; then
-    echo -e "${GREEN}${BOLD}All $INSTALLED plugins installed successfully!${NC}"
+    echo -e "${GREEN}${BOLD}All $TOTAL plugins ready ($INSTALLED installed, $UPDATED updated, $UP_TO_DATE already up to date).${NC}"
 else
-    echo -e "${YELLOW}${BOLD}$INSTALLED installed, $FAILED failed${NC}"
+    echo -e "${YELLOW}${BOLD}$TOTAL plugins processed: $INSTALLED installed, $UPDATED updated, $UP_TO_DATE already up to date, $FAILED failed.${NC}"
 fi
 
 echo

plugins/code/agents/plan-importer.md

@@ -20,7 +20,7 @@ You import an external markdown plan into the ClosedLoop `plan.json` format. You
 
 - `$CLOSEDLOOP_WORKDIR/plan.json` - Schema-compliant plan JSON
 - `$CLOSEDLOOP_WORKDIR/plan.md` - The markdown `content` field value (for human review)
-- `$CLOSEDLOOP_WORKDIR/.closedloop/imported-plan` - Marker file written on successful validation
+- `$CLOSEDLOOP_WORKDIR/.closedloop-ai/imported-plan` - Marker file written on successful validation
 
 ## Process
 
@@ -174,8 +174,8 @@ Common issues to fix:
 On successful validation (`status: "VALID"`), create the imported-plan marker:
 
 ```bash
-mkdir -p "$CLOSEDLOOP_WORKDIR/.closedloop"
-echo "imported" > "$CLOSEDLOOP_WORKDIR/.closedloop/imported-plan"
+mkdir -p "$CLOSEDLOOP_WORKDIR/.closedloop-ai"
+echo "imported" > "$CLOSEDLOOP_WORKDIR/.closedloop-ai/imported-plan"
 ```
 
 ## Quality Checklist
@@ -189,12 +189,12 @@ echo "imported" > "$CLOSEDLOOP_WORKDIR/.closedloop/imported-plan"
 | JSON sync | Structured arrays match markdown content exactly |
 | Valid JSON | No trailing commas, newlines escaped as `\n` in content string |
 | Validation | `validate_plan.py` returns `status: "VALID"` |
-| Marker file | `.closedloop/imported-plan` written on success |
+| Marker file | `.closedloop-ai/imported-plan` written on success |
 
 ## Completion
 
 Output `<promise>PLAN_IMPORTED</promise>` ONLY when ALL are true:
 
 1. `$CLOSEDLOOP_WORKDIR/plan.json` exists and passed validation (`status: "VALID"`)
 2. `$CLOSEDLOOP_WORKDIR/plan.md` exists and contains the markdown content
-3. `$CLOSEDLOOP_WORKDIR/.closedloop/imported-plan` marker file exists
+3. `$CLOSEDLOOP_WORKDIR/.closedloop-ai/imported-plan` marker file exists

plugins/code/hooks/loop-stop-hook.sh

@@ -47,7 +47,7 @@ fi
 
 # Source closedloop config from WORKDIR if found
 if [[ -n "$CLOSEDLOOP_WORKDIR" ]]; then
-  CLOSEDLOOP_CONFIG="$CLOSEDLOOP_WORKDIR/.closedloop/config.env"
+  CLOSEDLOOP_CONFIG="$CLOSEDLOOP_WORKDIR/.closedloop-ai/config.env"
   if [[ -f "$CLOSEDLOOP_CONFIG" ]]; then
     source "$CLOSEDLOOP_CONFIG"
   fi
@@ -90,14 +90,14 @@ STATE_FILE_SUFFIX=$(echo "$AGENT_CONFIG" | jq -r '.state_file_suffix // "loop.lo
 
 echo "$(date): Agent config - validation=$VALIDATION_SCRIPT, max_iter=$MAX_ITERATIONS_DEFAULT, promise=$PROMISE, state_suffix=$STATE_FILE_SUFFIX" >> "$DEBUG_LOG"
 
-# Build state file path (in CLOSEDLOOP_WORKDIR/.closedloop/)
+# Build state file path (in CLOSEDLOOP_WORKDIR/.closedloop-ai/)
 # Exit early if CLOSEDLOOP_WORKDIR is not set - no loop context
 if [[ -z "$CLOSEDLOOP_WORKDIR" ]]; then
   echo "$(date): No CLOSEDLOOP_WORKDIR, exiting loop-stop-hook" >> "$DEBUG_LOG"
   exit 0
 fi
 
-STATE_FILE="$CLOSEDLOOP_WORKDIR/.closedloop/$STATE_FILE_SUFFIX"
+STATE_FILE="$CLOSEDLOOP_WORKDIR/.closedloop-ai/$STATE_FILE_SUFFIX"
 
 if [[ ! -f "$STATE_FILE" ]]; then
   echo "$(date): No active loop - state file not found: $STATE_FILE" >> "$DEBUG_LOG"

plugins/code/hooks/pretooluse-hook.sh

@@ -139,7 +139,7 @@ DEBUG_LOG="$CLOSEDLOOP_WORKDIR/.learnings/pretooluse-hook-debug.log"
 echo "$(date): PreToolUse hook started, tool=$TOOL_NAME" >> "$DEBUG_LOG"
 
 # Source closedloop config and skip learning injection if disabled
-CLOSEDLOOP_CONFIG="$CLOSEDLOOP_WORKDIR/.closedloop/config.env"
+CLOSEDLOOP_CONFIG="$CLOSEDLOOP_WORKDIR/.closedloop-ai/config.env"
 if [[ -f "$CLOSEDLOOP_CONFIG" ]]; then
     source "$CLOSEDLOOP_CONFIG"
 fi

plugins/code/hooks/session-end-hook.sh

@@ -68,11 +68,6 @@ fi
 # Remove any orphaned .agent-types files in CLOSEDLOOP_WORKDIR (if known)
 # ============================================================================
 
-# Fallback: Check CWD's config.env (CLOSEDLOOP_WORKDIR was discovered above before cleanup)
-if [[ -z "$CLOSEDLOOP_WORKDIR" ]] && [[ -f "$CWD/.closedloop/config.env" ]]; then
-    source "$CWD/.closedloop/config.env"
-fi
-
 if [[ -n "$CLOSEDLOOP_WORKDIR" ]] && [[ -d "$CLOSEDLOOP_WORKDIR/.agent-types" ]]; then
     echo "$(date): Cleaning up agent-types directory: $CLOSEDLOOP_WORKDIR/.agent-types" >> "$DEBUG_LOG"
 

plugins/code/hooks/subagent-start-hook.sh

@@ -35,7 +35,7 @@ fi
 
 # Source closedloop config from WORKDIR if found
 if [[ -n "$CLOSEDLOOP_WORKDIR" ]]; then
-    CLOSEDLOOP_CONFIG="$CLOSEDLOOP_WORKDIR/.closedloop/config.env"
+    CLOSEDLOOP_CONFIG="$CLOSEDLOOP_WORKDIR/.closedloop-ai/config.env"
     if [[ -f "$CLOSEDLOOP_CONFIG" ]]; then
         source "$CLOSEDLOOP_CONFIG"
     fi
@@ -72,13 +72,13 @@ if [[ -f "$LOOP_CONFIG" ]] && [[ -n "$AGENT_TYPE" ]]; then
         MAX_ITERATIONS="${CLOSEDLOOP_MAX_ITERATIONS:-$CONFIG_MAX_ITERATIONS}"
         PRD_FILE="${CLOSEDLOOP_PRD_FILE:-}"
         WORKDIR="${CLOSEDLOOP_WORKDIR:-$CWD}"
-        STATE_FILE="$WORKDIR/.closedloop/$STATE_FILE_SUFFIX"
+        STATE_FILE="$WORKDIR/.closedloop-ai/$STATE_FILE_SUFFIX"
 
         echo "$(date): Loop agent detected: $AGENT_TYPE, state_file=$STATE_FILE" >> "$DEBUG_LOG"
 
         # Only create if state file doesn't exist (idempotent)
         if [[ ! -f "$STATE_FILE" ]] && [[ -n "$WORKDIR" ]]; then
-            mkdir -p "$WORKDIR/.closedloop"
+            mkdir -p "$WORKDIR/.closedloop-ai"
 
             PROMPT="Create a comprehensive implementation plan for the requirements in @${PRD_FILE}.
 

plugins/code/hooks/subagent-stop-hook.sh

@@ -36,7 +36,7 @@ fi
 
 # Source closedloop config from WORKDIR if found
 if [[ -n "$CLOSEDLOOP_WORKDIR" ]]; then
-    CLOSEDLOOP_CONFIG="$CLOSEDLOOP_WORKDIR/.closedloop/config.env"
+    CLOSEDLOOP_CONFIG="$CLOSEDLOOP_WORKDIR/.closedloop-ai/config.env"
     if [[ -f "$CLOSEDLOOP_CONFIG" ]]; then
         source "$CLOSEDLOOP_CONFIG"
     fi

plugins/code/scripts/run-loop.sh

@@ -732,8 +732,8 @@ $prompt
 EOF
 
   # Update config.env with self-learning flag (preserve other keys)
-  mkdir -p "$WORKDIR/.closedloop"
-  CONFIG_FILE="$WORKDIR/.closedloop/config.env"
+  mkdir -p "$WORKDIR/.closedloop-ai"
+  CONFIG_FILE="$WORKDIR/.closedloop-ai/config.env"
   TMP_FILE="${CONFIG_FILE}.tmp.$$"
   if [[ -f "$CONFIG_FILE" ]]; then
     sed '/^CLOSEDLOOP_SELF_LEARNING=/d' "$CONFIG_FILE" > "$TMP_FILE"

plugins/code/scripts/setup-closedloop.sh

@@ -223,7 +223,7 @@ while [[ $CURRENT_PID -gt 1 ]]; do
         break
     fi
     # Get parent PID
-    CURRENT_PID=$(ps -o ppid= -p $CURRENT_PID 2>/dev/null | tr -d ' ')
+    CURRENT_PID=$(ps -o ppid= -p """""$CURRENT"_"P"I"D" 2>/dev/null | tr -d ' ')
     if [[ -z "$CURRENT_PID" ]]; then
         break
     fi
@@ -290,7 +290,10 @@ else
     exit 1
 fi
 
-cat > "$WORKDIR/.closedloop/config.env" << EOF
+# Write full config to WORKDIR
+mkdir -p "$WORKDIR/.closedloop-ai"
+
+cat > "$WORKDIR/.closedloop-ai/config.env" << EOF
 CLOSEDLOOP_WORKDIR="$WORKDIR"
 CLOSEDLOOP_PRD_FILE="$PRD_FILE"
 CLOSEDLOOP_PLAN_FILE="$PLAN_FILE"
@@ -318,5 +321,5 @@ CLOSEDLOOP_ADD_DIR_NAMES="$add_dir_names_joined"
 CLOSEDLOOP_REPO_MAP="$repo_map_joined"
 EOF
 
-echo "ClosedLoop config written to $WORKDIR/.closedloop/config.env"
-cat "$WORKDIR/.closedloop/config.env"
+echo "ClosedLoop config written to $WORKDIR/.closedloop-ai/config.env"
+cat "$WORKDIR/.closedloop-ai/config.env"

plugins/code/scripts/setup-loop.sh

@@ -118,7 +118,7 @@ CONFIG_MAX_ITERATIONS=$(echo "$AGENT_CONFIG" | jq -r '.max_iterations // 10')
 # Use command line override or config default
 MAX_ITERATIONS="${MAX_ITERATIONS:-$CONFIG_MAX_ITERATIONS}"
 
-STATE_FILE="$WORKDIR/.closedloop/$STATE_FILE_SUFFIX"
+STATE_FILE="$WORKDIR/.closedloop-ai/$STATE_FILE_SUFFIX"
 
 # Idempotency checks
 if [[ -f "$WORKDIR/plan.json" ]]; then
@@ -132,7 +132,7 @@ if [[ -f "$STATE_FILE" ]]; then
 fi
 
 # Create state file
-mkdir -p "$WORKDIR/.closedloop"
+mkdir -p "$WORKDIR/.closedloop-ai"
 
 PROMPT="Create a comprehensive implementation plan for the requirements in @${PRD_FILE}.