Skip to content

Commit 7b4bb42

Browse files
wongkclaude
andauthored
docs(code-review): correct stale prefix-harness "Phase 4b" comments (#177)
PLN-1229 delivered the deterministic-prefix golden harness (prefix_golden_harness.py) and its subprocess A/B parity oracle, but two docstrings and the SCHEMA.md golden-fixture section still described that work as a future "Phase 4b" that "will extend" the post-collection harness. Update golden_fixture_harness.py, the cmd_prepare_run docstring, and SCHEMA.md section 12 to point at the delivered harness and note the orchestrator now runs the deterministic prefix in-process via run-prefix rather than walking those stages one at a time. Docs-only; bump 3.4.0 -> 3.4.1. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
1 parent dded59a commit 7b4bb42

5 files changed

Lines changed: 17 additions & 6 deletions

File tree

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ All notable changes to the claude-plugins project will be documented in this fil
44

55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). Entries are listed newest-first; each plugin section is treated as released when merged to `main`.
66

7+
### code-review v3.4.1
8+
9+
#### Fixed
10+
- Corrected stale documentation that described the deterministic-prefix golden harness as unbuilt future work. The `golden_fixture_harness.py` and `cmd_prepare_run` docstrings and the `SCHEMA.md` golden-fixture section now point at the delivered prefix harness (`prefix_golden_harness.py`) and its subprocess A/B parity oracle, and note that the orchestrator runs the deterministic prefix in-process via `run-prefix` rather than walking those stages one at a time.
11+
712
### code-review v3.4.0
813

914
#### Changed

plugins/code-review/.claude-plugin/plugin.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "code-review",
33
"description": "Code review plugin",
4-
"version": "3.4.0",
4+
"version": "3.4.1",
55
"author": {
66
"name": "ClosedLoop",
77
"email": "support@closedloop.ai"

plugins/code-review/SCHEMA.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -719,8 +719,10 @@ The remaining 3 fixtures requiring plans 03/05/06
719719
(`golden_impact_with_callsites`, `golden_coverage_gap`,
720720
`golden_budget_exceeded`) have reserved directories with READMEs and
721721
are skipped via a `_DEFERRED_FIXTURES` map in the test module until
722-
their dependent plans land. Phase 4b will extend the harness to walk
723-
`run_plan.json` end-to-end through a declarative stage runner.
722+
their dependent plans land. The deterministic prefix (stages `01` through
723+
Gate B) is pinned separately by `prefix_golden_harness.py` (PLN-1229
724+
Phase 0); its subprocess A/B parity oracle guards the in-process
725+
`run-prefix` batch runner byte-for-byte.
724726

725727
---
726728

plugins/code-review/tools/python/code_review_helpers.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11013,7 +11013,8 @@ def cmd_prepare_run(args: argparse.Namespace) -> int:
1101311013
"""Emit ``run_plan.json`` describing the full review pipeline.
1101411014

1101511015
PLN-719 Section 6. The output is consumed by the ``/start`` orchestrator,
11016-
which walks the plan stage-by-stage (Phase 4b).
11016+
which runs the deterministic prefix in-process via ``run-prefix``
11017+
(PLN-1229) and walks the reviewer tail stage-by-stage.
1101711018

1101811019
Determinism: same inputs produce byte-identical output **except for the
1101911020
``review_id`` field**, which is a fresh ``uuid.uuid4()`` per invocation.

plugins/code-review/tools/python/golden_fixture_harness.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,11 @@
1717
the wall-clock telemetry block) are normalized before diff/write so the
1818
expected files stay stable across runs.
1919
20-
Phase 8 ships the post-collection harness only. Phase 4b will extend it to
21-
walk ``run_plan.json`` end-to-end through a declarative stage runner.
20+
This module pins the post-collection half only (``collect-findings`` →
21+
``validate`` → ``finalize-result``). The deterministic prefix — stages ``01``
22+
through Gate B — is pinned separately by ``prefix_golden_harness.py``
23+
(PLN-1229 Phase 0), whose subprocess A/B parity oracle guards the in-process
24+
``run-prefix`` batch runner byte-for-byte.
2225
"""
2326

2427
from __future__ import annotations

0 commit comments

Comments
 (0)