Skip to content

Commit dc02b06

Browse files
wongkclaude
andcommitted
fix(code-review): restore GitHub-mode Impact gate count line; clarify v1 round-trip fixture
Two more residual-Premise-excision follow-ups: - github-review.md's Verifier Stats block was missing the Impact gateable count line that present-local/SKILL.md already shows. The Premise cumulative-gate display removed from both presenters was replaced only in local mode, leaving GitHub-mode operators with no line for stats.impact_cumulative_count (the envelope's sole operator-tunable verdict-gate count). Mirror the local-mode line before the Partition mode line. - Clarify the golden_schema_v1_round_trip fixture's config description. The SCHEMA_VERSION 1->2 bump restamps the envelope to 2 while each finding's own stamp is preserved, so the fixture round-trips a schema_version: 1 finding through a schema_version: 2 envelope. The finding is genuinely v1 (same as every other golden fixture's findings), so the name/"v1" are accurate -- not renamed; the description now states the v1-finding / v2-envelope split explicitly so it reads as the backward-compat probe it is. No behavior change. 1209 tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent a189ed1 commit dc02b06

3 files changed

Lines changed: 10 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
1616

1717
#### Fixed
1818
- Corrected documentation and a test left stale by the `Premise` removal and the renumbered verdict-precedence list. The cumulative Impact verdict gate is now referenced by name (FEA-1401 / PLN-726 OQ#6) in `start.md` and `README.md` rather than a bare ordinal that collided with `SCHEMA.md`'s sequential rules, and a numbering note in `SCHEMA.md` records that `_compute_canonical_verdict`'s plan-derived rule labels do not map 1:1 to that list. The `SCHEMA.md` deferred-fixture count now matches `_DEFERRED_FIXTURES` (3 deferred; `golden_injection_quarantine` is listed as a shipped fixture). The schema test that exercised the removed `stats.justification` / `stats.by_subcategory` telemetry sub-blocks now targets the live `stats.verification` sub-block (`justified_valid_count` / `justified_invalid_count` / `by_reviewer`).
19+
- Restored the operator-facing Impact gate count in GitHub-mode output: the `github-review.md` Verifier Stats block now shows `Impact gateable count` (`stats.impact_cumulative_count`, gate threshold `impact_cumulative`) to match the local-mode presenter — the removed Premise cumulative-gate display had left GitHub mode with no line for the envelope's sole operator-tunable verdict-gate count. Also clarified the `golden_schema_v1_round_trip` fixture description to reflect that it round-trips a `schema_version: 1` finding through the current `schema_version: 2` envelope (a v1-finding backward-compat probe), instead of implying a stale v1-only test.
1920

2021
### code-review v2.37.1
2122

plugins/code-review/prompts/github-review.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -302,6 +302,8 @@ Read `$CR_DIR/review_result.json` → `stats.verification`. If the block is not
302302

303303
The Reviewer column keys off the `reviewer` field, which `cmd_collect_findings` derives from the agent filename (`agent_bha_p0.json``reviewer='bha_p0'`). Under partitioned mode the table shows one BHA row per partition (`bha_p0`, `bha_p1`, …); under unified mode it shows a single `bha_p0` row because only one partition exists.
304304

305+
**Impact gateable count**: {stats.impact_cumulative_count} (gate threshold {impact_cumulative}) — read from `stats`. The envelope's sole operator-tunable verdict-gate count (the cumulative Impact gate; FEA-1401 / PLN-726 OQ#6).
306+
305307
**Partition mode** ({verify_manifest.partition_mode}, {verify_manifest.partition_count} partitions) — read from `<CR_DIR>/verify_manifest.json`. Omit this line when the manifest file is absent (hygiene-only run or pre-PLN-774 cache).
306308

307309
</details>

plugins/code-review/tools/python/fixtures/golden_schema_v1_round_trip/config.yaml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
11
# PLN-719 Section 10 fixture: schema round-trip exemplar.
22
# A single finding with every optional schema field populated
33
# (evidence[], reasoning_certificate, other_locations) so the produced
4-
# envelope exercises the maximal v1 shape. The harness's always-on
5-
# validate_result_envelope call pins the round-trip contract.
6-
description: "Maximal v1 finding shape — every optional field populated for round-trip."
4+
# envelope exercises the maximal finding shape. The input finding declares
5+
# schema_version 1; the SCHEMA_VERSION 1->2 bump restamps the envelope to the
6+
# current version (2) while each finding's own stamp is preserved — so this
7+
# fixture doubles as a v1-finding backward-compat probe: the current validator
8+
# still round-trips a finding that declares schema_version 1. The harness's
9+
# always-on validate_result_envelope call pins the round-trip contract.
10+
description: "Maximal finding shape (every optional field populated) declaring schema_version 1, round-tripped through the current schema_version-2 envelope — also pins v1-finding backward-compat."
711
mode: github
812
diff_tip: "deadbeef"
913
expected_verdict: NEEDS_ATTENTION

0 commit comments

Comments
 (0)