Commit dc02b06
fix(code-review): restore GitHub-mode Impact gate count line; clarify v1 round-trip fixture
Two more residual-Premise-excision follow-ups:
- github-review.md's Verifier Stats block was missing the Impact gateable
count line that present-local/SKILL.md already shows. The Premise
cumulative-gate display removed from both presenters was replaced only in
local mode, leaving GitHub-mode operators with no line for
stats.impact_cumulative_count (the envelope's sole operator-tunable
verdict-gate count). Mirror the local-mode line before the Partition mode line.
- Clarify the golden_schema_v1_round_trip fixture's config description. The
SCHEMA_VERSION 1->2 bump restamps the envelope to 2 while each finding's own
stamp is preserved, so the fixture round-trips a schema_version: 1 finding
through a schema_version: 2 envelope. The finding is genuinely v1 (same as
every other golden fixture's findings), so the name/"v1" are accurate -- not
renamed; the description now states the v1-finding / v2-envelope split
explicitly so it reads as the backward-compat probe it is.
No behavior change. 1209 tests pass.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent a189ed1 commit dc02b06
3 files changed
Lines changed: 10 additions & 3 deletions
File tree
- plugins/code-review
- prompts
- tools/python/fixtures/golden_schema_v1_round_trip
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
302 | 302 | | |
303 | 303 | | |
304 | 304 | | |
| 305 | + | |
| 306 | + | |
305 | 307 | | |
306 | 308 | | |
307 | 309 | | |
| |||
Lines changed: 7 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
6 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
7 | 11 | | |
8 | 12 | | |
9 | 13 | | |
| |||
0 commit comments