This repository was archived by the owner on Jun 8, 2026. It is now read-only.
Commit 09e9df4
committed
FEA-1497: Fix pre-existing lint errors blocking CI (Phase 0)
The CI "Tests" job runs `pnpm lint` as a step (bash -e), so the 19
pre-existing eslint errors on PR #264 failed the whole check before the
test run. Clear them so CI is green.
Unused imports/vars (dead code in 264's renderer + DB layer):
- database/index.ts: drop unused SessionRow/AgentRow/EventRow/
HookEventPayload type imports.
- DashboardPage.tsx: drop unused Card*/Badge/RankedBar imports and the
now-orphaned toolUsage/maxToolCount locals.
- ApprovalsPanel.tsx: drop unused CardHeader/CardTitle.
- Topbar.tsx / SettingsPanel.tsx: drop unused useCallback.
eslint config (parserOptions.project parse errors on 4 renderer files):
- src/renderer is Vite-built and excluded from tsconfig.json, so its
.ts/.d.ts files cannot resolve under the type-aware lint block (project:
./tsconfig.json). Add `ignores: ["src/renderer/**"]` to that block so
renderer files are linted by the recommended (syntactic) config instead
of erroring; matches the existing tsconfig boundary.
Testing (CI-equivalent, all green locally):
- pnpm install --frozen-lockfile: exit 0
- pnpm -C apps/desktop lint: 0 errors
- pnpm typecheck (-r): exit 0
- pnpm test (-r): exit 0 (0 failures; 14 skips: 13 generated-gated + 2
documented FEA-1497 retarget-skips)
Risks:
- Renderer (.ts/.tsx) is now linted without type-aware rules
(no-floating-promises), consistent with it being outside the tsconfig
program; full renderer type-aware lint + typecheck is a Phase 1 follow-up.
- Import removals are dead-code only; no behavior change.1 parent 3911766 commit 09e9df4
6 files changed
Lines changed: 9 additions & 11 deletions
File tree
- apps/desktop
- src
- main/database
- renderer/components
- approvals
- dashboard
- layout
- settings
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
10 | 16 | | |
11 | 17 | | |
12 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
Lines changed: 0 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
4 | 2 | | |
5 | | - | |
6 | 3 | | |
7 | 4 | | |
8 | 5 | | |
| |||
41 | 38 | | |
42 | 39 | | |
43 | 40 | | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | 41 | | |
48 | 42 | | |
49 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | 1 | | |
4 | 2 | | |
5 | 3 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
0 commit comments