FEA-1550: Review feedback hardening for SQLite->PGlite migration

- Restrict backup cleanup to exact naming pattern, regular files only, no recursive delete
- Stamp backup mtime with migration time instead of preserving SQLite mtime
- Stage PGlite in temp directory, promote only after backup succeeds
- Sanitize absolute paths and error stacks from logs
- Batch inserts (500 rows) instead of per-row INSERT
- Validate all SQLite tables are managed before migration
- Require .bak + .pgdata for already_migrated; detect downgrade scenario
- Wire migration into startup with keepSource, non-blocking background execution
- Pass startup result to runtime for PGlite readiness signaling

Testing: Full migration test suite (9 tests), typecheck, and lint pass

Author: mikeangstadt

apps/desktop/package.json

@@ -1,6 +1,6 @@
 {
   "name": "desktop",
-  "version": "0.16.0",
+  "version": "0.16.1",
   "description": "ClosedLoop Desktop",
   "author": "ClosedLoop AI <support@closedloop.ai>",
   "private": true,

apps/desktop/src/main/agent-dashboard-database-startup.ts

@@ -1,4 +1,4 @@
-import path from "node:path";
+import { basename, join } from "node:path";
 import {
   cleanupExpiredSqliteBackups,
   migrateSqliteToPglite,
@@ -19,22 +19,16 @@ export type AgentDashboardDatabaseStartupResult =
       backend: "pglite";
       sqlitePath: string;
       pgliteDataDir: string;
-      migration: SqliteToPgliteMigrationResult;
+      migration?: SqliteToPgliteMigrationResult;
+      migrationPromise: Promise<SqliteToPgliteMigrationResult>;
     };
 
 export function resolveAgentDashboardDatabasePathForUserData(
   userDataPath: string,
 ): string {
-  return path.join(userDataPath, "agent-dashboard.sqlite");
+  return join(userDataPath, "agent-dashboard.sqlite");
 }
 
-/**
- * Startup-owned preparation for the dashboard database engine. SQLite mode only
- * performs stale backup cleanup so the current SQLite runtime cannot rename its
- * own live database. PGlite mode runs the forward migration before the PGlite
- * runtime opens; failure returns a SQLite fallback result and leaves the source
- * DB intact for retry on the next launch.
- */
 export async function prepareAgentDashboardDatabaseStartup(options: {
   userDataPath: string;
   backend: AgentDashboardDatabaseBackend;
@@ -46,39 +40,54 @@ export async function prepareAgentDashboardDatabaseStartup(options: {
   const pgliteDataDir = resolvePgliteDataDir(sqlitePath);
   const log = options.log ?? (() => {});
 
+  const removed = await cleanupExpiredSqliteBackups(sqlitePath);
+  if (removed > 0) {
+    log(
+      "agent-dashboard-migration",
+      `Removed ${removed} expired SQLite backup(s) for ${basename(sqlitePath)}`,
+    );
+  }
+
   if (options.backend === "sqlite") {
-    const removed = await cleanupExpiredSqliteBackups(sqlitePath);
-    if (removed > 0) {
+    return { backend: "sqlite", sqlitePath, pgliteDataDir };
+  }
+
+  const onSettled = (migration: SqliteToPgliteMigrationResult) => {
+    if (migration.status === "failed") {
       log(
         "agent-dashboard-migration",
-        `Removed ${removed} expired SQLite backup(s) for ${sqlitePath}`,
+        `PGlite migration failed (runtime continues on SQLite): ${migration.error}`,
+      );
+    } else if (migration.status === "migrated") {
+      log(
+        "agent-dashboard-migration",
+        `PGlite migration completed (${migration.rowCounts.sessions} sessions); SQLite preserved for sync runtime`,
       );
     }
-    return { backend: "sqlite", sqlitePath, pgliteDataDir };
-  }
+    return migration;
+  };
 
-  const migration = await migrateSqliteToPglite({
+  const migrationPromise = migrateSqliteToPglite({
     sqlitePath,
     pgliteDataDir,
+    keepSource: true,
     log: (message) => log("agent-dashboard-migration", message),
-  });
-  if (migration.status === "failed") {
-    log(
-      "agent-dashboard-migration",
-      `Falling back to SQLite after PGlite migration failure: ${migration.error}`,
-    );
+  }).then(onSettled, (error: unknown) => {
+    const err = error instanceof Error ? error.message : String(error);
+    log("agent-dashboard-migration", `PGlite migration failed: ${err}`);
     return {
-      backend: "sqlite",
+      status: "failed" as const,
       sqlitePath,
       pgliteDataDir,
-      migration,
+      error: err,
+      failedAt: new Date().toISOString(),
     };
-  }
+  });
 
   return {
     backend: "pglite",
     sqlitePath,
     pgliteDataDir,
-    migration,
+    migrationPromise,
   };
 }

apps/desktop/src/main/agent-dashboard-design-system-runtime.ts

@@ -10,7 +10,10 @@ import { detectBillingMode } from "./billing-mode-detector.js";
 import { openAgentDatabase, type AgentDatabase } from "./database/index.js";
 import { coerceDbId } from "./database/ipc-validation.js";
 import { createLifecycle } from "./database/lifecycle.js";
-import { resolveAgentDashboardDatabasePathForUserData } from "./agent-dashboard-database-startup.js";
+import {
+  resolveAgentDashboardDatabasePathForUserData,
+  type AgentDashboardDatabaseStartupResult,
+} from "./agent-dashboard-database-startup.js";
 import { isAgentMonitorHooksEnabled } from "./agent-monitor-hooks.js";
 
 export { prepareAgentDashboardDatabaseStartup } from "./agent-dashboard-database-startup.js";
@@ -37,6 +40,7 @@ export interface AgentDashboardDesignSystemRuntimeOptions {
   onTerminalFailure: (reason: string) => void;
   userDataPath?: string;
   log?: (scope: string, message: string) => void;
+  startupResult?: AgentDashboardDatabaseStartupResult;
 }
 
 export interface AgentDashboardDesignSystemRuntime {
@@ -71,6 +75,28 @@ export function createAgentDashboardDesignSystemRuntime(
   options: AgentDashboardDesignSystemRuntimeOptions,
 ): AgentDashboardDesignSystemRuntime {
   const log = options.log ?? (() => {});
+  const startupResult = options.startupResult;
+
+  if (startupResult?.backend === "pglite") {
+    log(
+      "agent-dashboard-migration",
+      "PGlite migration kicked off in background; SQLite runtime active during migration",
+    );
+    void startupResult.migrationPromise.then((migration) => {
+      if (migration.status === "failed") {
+        log(
+          "agent-dashboard-migration",
+          `PGlite migration failed: ${migration.error}`,
+        );
+      } else {
+        log(
+          "agent-dashboard-migration",
+          `PGlite migration completed (${migration.status === "migrated" ? `${migration.rowCounts.sessions} sessions` : "skipped"})`,
+        );
+      }
+    });
+  }
+
   const agentDatabase = openAgentDatabase(
     resolveAgentDashboardDatabasePath(options.userDataPath),
   );

apps/desktop/src/main/app.ts

@@ -1515,9 +1515,9 @@ export class DesktopApplication {
       } = await import(
         "./agent-dashboard-design-system-runtime.js"
       );
-      await prepareAgentDashboardDatabaseStartup({
+      const startupResult = await prepareAgentDashboardDatabaseStartup({
         userDataPath: app.getPath("userData"),
-        backend: "sqlite",
+        backend: "pglite",
         log: (scope, message) => gatewayLog.info(scope, message),
       });
       this.agentDashboardDesignSystem =
@@ -1537,6 +1537,7 @@ export class DesktopApplication {
             this.refreshTrayState();
           },
           log: (scope, message) => gatewayLog.info(scope, message),
+          startupResult,
         });
       this.agentDashboardDesignSystem.registerIpcHandlers();
     }