FEA-1437: Phase 4 — Tools selector binding + dom_count assertion pattern

- audit-tile.ts: new dom_count branch — for list_length/section_card_count tiles
  (no single numeric element), assert the rendered item count == oracle via
  toHaveCount(selector). Generalizes the table-driven audit to count tiles.
- Tools.tsx: data-testid='audit-tool-row' on each tool button. tools.list.length
  now asserts count == events_facets_tool_names_length (passes).
- specs/audit/tools.ui-audit.spec.ts: new spec; skips tiles not yet bound
  (tools.event_types.length — event_type has no countable rendered list; only
  shows per-event in the detail panel) with a visible "(skip — selector pending)".
- Plans.tsx: data-testid='audit-plan-row' added (infra for later) but the Plans
  UI audit is NOT enabled — the fixture seeds zero plans, so it can't be
  meaningfully asserted yet; manifest followup documents the fixture-seeding
  prerequisite. No Plans spec shipped (would be empty/false-confidence).
- coverage.json: detection line numbers refreshed after the testid edits.

Testing: test:audit:ui -> 9 passed / 5 skipped / 0 failed.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: Andrew Eye

apps/desktop/scripts/agent-monitor-packs/client/Tools.tsx

@@ -125,6 +125,7 @@ export function Tools() {
               return (
                 <button
                   key={t.tool_name}
+                  data-testid="audit-tool-row"
                   onClick={() => setSelected(t.tool_name)}
                   className={`block w-full text-left rounded-lg border px-3 py-2 transition-colors ${
                     active

apps/desktop/scripts/agent-monitor-plans/client/Plans.tsx

@@ -166,6 +166,7 @@ export function Plans() {
               return (
                 <button
                   key={p.id}
+                  data-testid="audit-plan-row"
                   onClick={() => setSelectedId(p.id)}
                   className={`block w-full text-left rounded-lg border px-3 py-2 transition-colors ${
                     active

apps/desktop/test-e2e/agent-monitor/helpers/audit-tile.ts

@@ -54,7 +54,11 @@ export async function assertTileMatchesOracle(
     oracle: string;
     tile_kind?: string;
     trend_label?: string;
-    selector?: { value?: string; present_in_code?: boolean };
+    selector?: {
+      value?: string;
+      present_in_code?: boolean;
+      render_kind?: string;
+    };
   },
 ): Promise<void> {
   const db = openDb(resolveFixtureDbPath());
@@ -68,6 +72,22 @@ export async function assertTileMatchesOracle(
     db.close();
   }
 
+  // dom_count tiles (list_length / section_card_count): there is no single
+  // numeric element — the tile's value IS the number of rendered item nodes.
+  // Assert the count of the item selector equals the oracle. selector.value is
+  // the per-item selector for these tiles (e.g. [data-testid='audit-plan-row']).
+  if (row.selector?.render_kind === "dom_count" && row.selector.present_in_code) {
+    const expectedCount = Number(expectedRaw);
+    await expect(
+      page.locator(row.selector.value as string),
+      `\n  manifest id: ${row.id}\n` +
+        `  oracle:      ${row.oracle} -> ${expectedRaw}\n` +
+        `  selector:    ${row.selector.value} (counted)\n` +
+        `  note:        dom_count tile — rendered item count must equal oracle.\n`,
+    ).toHaveCount(expectedCount);
+    return;
+  }
+
   const region = await sliceForTile(page, row);
 
   if (row.tile_kind === "trend") {

apps/desktop/test-e2e/agent-monitor/inventory/coverage.json

@@ -1147,7 +1147,7 @@
       "detection_id": "auto.tools.102",
       "screen": "Tools",
       "file": "apps/desktop/scripts/agent-monitor-packs/client/Tools.tsx",
-      "line": 155,
+      "line": 156,
       "detected_kind": "formatter_call",
       "value_expr": "fmt(ev.created_at)",
       "status": "out_of_scope",
@@ -1157,7 +1157,7 @@
       "detection_id": "auto.plans.103",
       "screen": "Plans",
       "file": "apps/desktop/scripts/agent-monitor-plans/client/Plans.tsx",
-      "line": 209,
+      "line": 210,
       "detected_kind": "formatter_call",
       "value_expr": "fmt(v.created_at)",
       "status": "out_of_scope",

apps/desktop/test-e2e/agent-monitor/inventory/manifest.json

@@ -821,11 +821,11 @@
       "status": "pending",
       "bug_ref": null,
       "selector": {
-        "value": "[data-testid='audit-tools-list-length']",
-        "present_in_code": false,
+        "value": "[data-testid='audit-tool-row']",
+        "present_in_code": true,
         "render_kind": "dom_count",
-        "renders_at": "scripts/agent-monitor-packs/client/Tools.tsx:123",
-        "followup": "Either add a numeric total element with a data-testid, or test by counting rendered items under a data-testid'd .map(tools) container."
+        "renders_at": "scripts/agent-monitor-packs/client/Tools.tsx (one button per distinct tool from /api/events/facets; testid added FEA-1437 Phase 4)",
+        "followup": "Done — each tool row has data-testid='audit-tool-row'; the audit asserts toHaveCount == events_facets_tool_names_length."
       }
     },
     {
@@ -891,11 +891,11 @@
       "status": "pending",
       "bug_ref": null,
       "selector": {
-        "value": "[data-testid='audit-plans-total']",
+        "value": "[data-testid='audit-plan-row']",
         "present_in_code": false,
         "render_kind": "dom_count",
-        "renders_at": "scripts/agent-monitor-plans/client/Plans.tsx:164",
-        "followup": "Either add a numeric total element with a data-testid, or test by counting rendered items under a data-testid'd .map(plans) container."
+        "renders_at": "scripts/agent-monitor-plans/client/Plans.tsx (one button per plan; data-testid='audit-plan-row' added FEA-1437 Phase 4)",
+        "followup": "testid + dom_count assertion ready, but UI audit is BLOCKED on fixture data — seed-fixture-db.mjs seeds no plans, so /api/plans returns 0. Before enabling: seed N plan rows, confirm planStore.listPlans count == countPlans (no version-join drop), then flip present_in_code true and add specs/audit/plans.ui-audit.spec.ts (dom_count branch already supports it)."
       }
     },
     {
@@ -917,8 +917,8 @@
         "value": "[data-testid='audit-tools-event-types-length']",
         "present_in_code": false,
         "render_kind": "dom_count",
-        "renders_at": "scripts/agent-monitor-packs/client/Tools.tsx:123",
-        "followup": "Either add a numeric total element with a data-testid, or test by counting rendered items under a data-testid'd .map(event facets) container."
+        "renders_at": "scripts/agent-monitor-packs/client/Tools.tsx — NOT rendered as a countable list. event_type only appears per-event in the right-hand detail panel; there is no distinct-event-types card list.",
+        "followup": "BLOCKED: no rendered element represents the distinct-event-types count. Add a count element (data-testid) on the Tools screen, or descope this tile. The Tools audit spec skips it (present_in_code false)."
       }
     },
     {

apps/desktop/test-e2e/agent-monitor/specs/audit/tools.ui-audit.spec.ts

@@ -0,0 +1,47 @@
+// Layer-2 audit: Tools screen. `tools.list.length` is a dom_count tile — one
+// button per distinct tool from /api/events/facets, so the rendered row count
+// must equal the events_facets_tool_names_length oracle. `tools.event_types.length`
+// has no countable rendered element yet (event_type only shows per-event in the
+// detail panel) so it is skipped until bound. Shared logic in audit-tile.ts.
+
+import { expect, test } from "@playwright/test";
+
+import {
+  loadManifest,
+  tilesForScreen,
+} from "../../inventory/manifest-loader.mjs";
+// @ts-expect-error — .ts helper imported by Playwright's ts loader
+import { assertTileMatchesOracle } from "../../helpers/audit-tile";
+
+const manifest = loadManifest();
+const toolTiles = tilesForScreen(manifest, "Tools");
+
+test.describe("Tools tiles · UI audit (manifest-driven)", () => {
+  test.beforeEach(async ({ page }) => {
+    await page.goto("/tools");
+    await expect
+      .poll(
+        async () => page.locator("[data-testid='audit-tool-row']").count(),
+        { timeout: 10_000 },
+      )
+      .toBeGreaterThan(0);
+  });
+
+  for (const row of toolTiles) {
+    // Skip tiles with a filed bug, or tiles not yet bound to a selector
+    // (no countable rendered element). Visible skip > silent drop.
+    const pending = !row.bug_ref && !row.selector?.present_in_code;
+    const testFn = row.bug_ref || pending ? test.skip : test;
+    const suffix = row.bug_ref
+      ? ` (skip — bug ${row.bug_ref})`
+      : pending
+        ? " (skip — selector pending)"
+        : "";
+    testFn(
+      `UI audit · ${row.id} matches oracle "${row.oracle}"${suffix}`,
+      async ({ page }) => {
+        await assertTileMatchesOracle(page, row);
+      },
+    );
+  }
+});