This repository was archived by the owner on Jun 8, 2026. It is now read-only.
Conversation
Truncate request/response bodies to 8KB in ActivityLogStore to prevent the persisted JSON from growing unbounded (was 100MB). On startup, migrate existing oversized bodies and trim excess entries. Handle approval-not-found gracefully in IPC handlers instead of throwing, preventing errors when approvals expire between UI render and user action.
AI-402 Fix ANR in electron app
Activity log is storing full log outputs and that's bringing our app to a halt. We'll truncate the responses. |
![closedloop-ai-stage[bot]](https://avatars.githubusercontent.com/in/2453960?s=60&v=4){kind=small}
Code Review SummaryStatus: Approved Reviewers: Bug Hunter A, Bug Hunter B, Unified Auditor, Premise Reviewer, persistence-expert Findings
MEDIUM Issues (consider)
Validation Stats
Recommendation: Approve — no blocking or high-priority issues found. Two medium-severity correctness nits are worth considering but do not block merge. |
Return consistent { pendingApprovals, settings } shape from the
always-allow-approval early-exit path. Also remove the second throw
for the same race condition. Change truncation label from "bytes" to
"chars" since body.length measures JS characters not UTF-8 bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Truncate request/response bodies to 8KB in ActivityLogStore to prevent the persisted JSON from growing unbounded (was 100MB). On startup, migrate existing oversized bodies and trim excess entries.
Handle approval-not-found gracefully in IPC handlers instead of throwing, preventing errors when approvals expire between UI render and user action.