Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

FEAT-69: add ESLint with TypeScript support to desktop app - #27

Merged
shafty023 merged 1 commit into
mainfrom
FEAT-69
Mar 17, 2026
Merged

shafty023 merged 1 commit into
mainfrom
FEAT-69

Conversation

@shafty023

Copy link
Copy Markdown
Contributor
  • Configure ESLint flat config with @typescript-eslint recommended rules
  • Add lint script and just desktop-lint command
  • Add lint step to CI workflow (before typecheck)
  • Properly type response wrappers in router.ts (remove all any usage)

Comment thread apps/desktop/eslint.config.js Outdated
@closedloop-ai-stage

Copy link
Copy Markdown

Code Review Summary

Status: Approved

Reviewers: Bug Hunter A, Bug Hunter B, Unified Auditor, Premise Reviewer, gateway-core-architect

Findings

Severity Count
Blocking 0
High 0
Medium 1

MEDIUM Issues (consider)

  1. [P2] [apps/desktop/eslint.config.js:17] tsPlugin.configs.recommended.rules is undefined in @typescript-eslint v8 flat config — recommended rules silently not applied

Validation Stats

  • Agent failures: 0 partitions skipped
  • Cross-file grouped: 0 findings consolidated
  • Discarded (line not changed): 1

Recommendation: Approve — no blocking or high-priority issues. One medium-severity correctness issue in the ESLint config is worth addressing.

- Configure ESLint flat config with @typescript-eslint recommended rules
- Add lint script and just desktop-lint command
- Add lint step to CI workflow (before typecheck)
- Properly type response wrappers in router.ts (remove all any usage)
- Bump version to 0.4.1

FEAT-69
@shafty023
shafty023 merged commit 86e2bd4 into main Mar 17, 2026
2 checks passed
@shafty023
shafty023 deleted the FEAT-69 branch March 17, 2026 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant