This repository was archived by the owner on Jun 8, 2026. It is now read-only.
Conversation
Bump desktop tooling to the Vite 7 and Node 24 development baseline, align CI/docs, and add a version freshness check for release candidates. Validation: git diff --check; desktop version check against origin/main; pnpm install --frozen-lockfile; pnpm -C apps/desktop build:renderer; just desktop-build; just desktop-typecheck; just desktop-lint; just desktop-test.
Resolve the branch conflict by keeping desktop 0.15.113 above main while preserving the Node 24/Vite 7 dependency baseline. Testing: Full desktop validation passed, including frozen install, renderer build, desktop build, typecheck, lint, and desktop tests. Risks: Low; merge-only update with the dependency baseline unchanged.
shafty023
marked this pull request as ready for review
June 5, 2026 20:12
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 51b2c744ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Pin the desktop @types/node dev dependency to exact 24.12.4 so ambient Node APIs match the supported runtime. - Add a repo rule for keeping Node ambient types aligned with runtime baseline changes. Testing: Full desktop build, test, typecheck, lint, and frozen install passed. Risks: Low; dependency-only type baseline change, no runtime code paths changed.
thadeusb
reviewed
Jun 5, 2026
thadeusb
approved these changes
Jun 5, 2026
thadeusb
left a comment
thadeusb
left a comment
Contributor
There was a problem hiding this comment.
Node 24 baseline and Vite 7 bump are straightforward, version freshness check is a good add. One question on the Electron binary step in test.yml.
Move the Electron binary repair guard into a reusable desktop script, then call it from the CI test and release workflows that run desktop tests or package/release under Node 24. Document the reusable workflow rule in AGENTS.md so future changes do not reintroduce inline Electron download logic or apply the guard to static/headless audit jobs. Validation: pnpm -C apps/desktop verify:electron-binary repair path passed; pnpm -C apps/desktop verify:electron-binary no-op path passed; pnpm install --frozen-lockfile passed; pnpm -r prebuild passed; pnpm -C apps/desktop lint passed; pnpm typecheck passed; pnpm -C apps/desktop assert:design-system-boundary passed; pnpm -C apps/desktop test:boot:design-system-off passed; pnpm -C apps/desktop measure:agent-dashboard-storage passed; pnpm test passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Work Item
Validation
git diff --checkorigin/mainpnpm install --frozen-lockfilepnpm -C apps/desktop build:rendererjust desktop-buildjust desktop-typecheckjust desktop-lintjust desktop-testKnown Blockers
None.