Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

Adopt pnpm 11 install policy - #272

Merged
shafty023 merged 2 commits into
mainfrom
fea-1545
Jun 6, 2026
Merged

shafty023 merged 2 commits into
mainfrom
fea-1545

Conversation

@shafty023

Copy link
Copy Markdown
Contributor

Summary

  • Updates the desktop workspace package manager and setup docs to pnpm 11.3.0.
  • Replaces the pnpm 10 build-script allowlist with pnpm 11 allowBuilds approvals for audited desktop install scripts.
  • Keeps unreviewed transitive build scripts denied unless a reviewed desktop path requires them.

Links

Validation

  • rtk just build: passed
  • rtk ruby policy assertions: passed
  • rtk pnpm ignored-builds: passed; no automatically ignored builds, with explicit denials for @scarf/scarf, better-sqlite3, and sharp
  • rtk git diff --check: passed
  • Prior implementation QA evidence: clean frozen install, negative allowBuilds mutation checks, Electron binary verification, esbuild native validation through the transitive owner path, electron-winstaller dependency-chain check, lint, typecheck, and tests all passed for the assigned repos
  • Pre-PR review evidence: passed with no findings or blockers

Known Blockers / Debt

  • No blockers.
  • Full Windows installer packaging was not run on this macOS host; substitute coverage includes dependency-chain proof for electron-winstaller plus build/lint/typecheck/test validation.

Updates the desktop workspace to pnpm 11.3.0 and replaces onlyBuiltDependencies with allowBuilds approvals for audited desktop install scripts.

Keeps unreviewed transitive build scripts denied unless a reviewed desktop path requires them.
@shafty023
shafty023 marked this pull request as ready for review June 6, 2026 04:45
@shafty023
shafty023 requested a review from a team June 6, 2026 04:45
Run the workflow for every PR and no-op when apps/desktop is unchanged so branch protection receives the required context without forcing irrelevant version bumps.
@shafty023
shafty023 merged commit 09cf797 into main Jun 6, 2026
5 checks passed
@shafty023
shafty023 deleted the fea-1545 branch June 6, 2026 05:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants