This repository was archived by the owner on Jun 8, 2026. It is now read-only.
fix: add -p flag to REQUEST_CHANGES spawn for headless permission grants - #31
Merged
Merged
Conversation
Code Review SummaryStatus: Approved Reviewers: Bug Hunter A, Bug Hunter B, Unified Auditor, Premise Reviewer, gateway-core-architect Findings
No issues found. Validation Stats
Recommendation: Approve |
aponamarev
added a commit
that referenced
this pull request
Mar 20, 2026
…_CHANGES PR #30 branched before PRs #31-#33 landed, leaving all three commands on the old spawnClaudeFromFile path (--output-format json, no streaming, no token tracking, no --allowedTools, no --max-turns). This commit brings parity with the fixes merged to main: - Add findStreamFormatter() and buildClaudePipeline() (ported from main) - DECOMPOSE: switch from spawnClaudeFromFile to buildClaudePipeline with -p -, --output-format stream-json, --verbose, --allowedTools, --max-turns 200 - EVALUATE_PRD: same treatment — produces claude-output.jsonl for token tracking, claude-stderr.log for debugging, and readable formatted logs - REQUEST_CHANGES: add -p, --output-format stream-json, --verbose, and route through buildClaudePipeline (was spawning claude directly) - Remove now-dead spawnClaudeFromFile helper Testing: `just desktop-typecheck` clean; all 242 tests pass Risks: None — behaviour change is intentional parity fix; formatter falls back gracefully when stream_formatter.py is not installed Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
REQUEST_CHANGES was spawning Claude without
-p(headless mode), causing it to hang waiting for interactive permission approval in a detached process.PLAN/EXECUTE use
run-loop.shwhich passes-p. DECOMPOSE already had-p. Only REQUEST_CHANGES was missing it.Without
-p,--allowedToolsis just a suggestion — Claude still prompts for file edit permissions. With-p,--allowedToolsgrants full permission without prompting.Test plan