This repository was archived by the owner on Jun 8, 2026. It is now read-only.
Conversation
- Add GENERATE_PRD to LoopCommand, VALID_COMMANDS, and LocalJobCommand
- Create writeArtifactsForGeneratePrd to write context pack files
(prompt.md, repo-info.json, artifacts/) under worktreeDir/.claude/context/
- Create readGeneratePrdOutputs to read prd.md from worktree root and
return { prd: { content } } matching generatePrdUploadSchema
- Add dedicated worktree branch namespace (symphony/generate-prd-<key>)
with always-fresh creation to avoid collisions with PLAN/EXECUTE
- Add prompt validation (400 for missing/empty/non-string prompt)
- Spawn claude with write-capable tools and cwd: worktreeDir
- Add cleanupGeneratePrdWorktree helper for worktree removal on both
success and failure paths, including pre-spawn early returns
- Add 7 integration tests covering rejection, context pack layout,
upload shape, no-output path, and worktree cleanup
Testing: TypeScript compiles clean, 7/7 new tests pass, 5/5 SSRF
regression tests pass
Risks: None identified -- new command path only, existing commands
untouched
thadeusb
reviewed
Mar 20, 2026
| * Mirrors writeContextPackFiles in harness-agent.mjs (lines 744-816). | ||
| * Files go under worktreeDir/.claude/context/ (NOT claudeWorkDir). | ||
| */ | ||
| async function writeArtifactsForGeneratePrd( |
Contributor
There was a problem hiding this comment.
Something like this got refactored in #30
good to synchronize on the correct one-true-way to do this.
thadeusb
approved these changes
Mar 20, 2026
thadeusb
left a comment
Contributor
There was a problem hiding this comment.
one nit about two prs adding very similar funcs
Code Review SummaryStatus: Needs Attention Reviewers: Bug Hunter A, Bug Hunter B, Unified Auditor, Premise Reviewer, Gateway Core Architect Findings
HIGH Issues (should fix)
MEDIUM Issues (consider)
Validation Stats
Recommendation: Address the HIGH issue (missing version bump) before merging - CI will block without it. The MEDIUM issues around cleanup deduplication and test reliability are worth fixing but not blocking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: TypeScript compiles clean, 7/7 new tests pass, 5/5 SSRF regression tests pass
Risks: None identified -- new command path only, existing commands untouched