This repository was archived by the owner on Jun 8, 2026. It is now read-only.
PLAN-108: Fix loop runner PR title format and artifact links - #53
Merged
Merged
Conversation
- Replace /artifact/by-slug/ with /implementation-plans/ in both
LLM commit prompt footer and SAFETY commit PR body
- Fix SAFETY commit PR title to use "PLAN-##: Automated changes
from loop {shortId}" format via shared fallbackTitle constant
- Resolve claude binary path at first use via which/login-shell
to handle Electron's restricted PATH
- Add assertPathAllowed sandbox gate before LLM commit spawn
- Write PID file atomically via .pid.tmp rename
- Replace unsafe JSON.parse cast with proper isExecutionResult
type guard using unknown intermediate and shape checks
- Add sanitizeCommitMessage doc comment re: backtick safety
- Add 3 new integration tests (artifact links, PR title format,
LLM spawn correctness)
Testing: All 12 EXECUTE loop tests pass
Risks: Low — changes isolated to symphony-loop.ts post-processing
mikeangstadt
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/artifact/by-slug/artifact links with correct/implementation-plans/URLs in both the LLM commit prompt and SAFETY commit PR bodyPLAN-##: Automated changes from loop {shortId}format via sharedfallbackTitleconstant (wasSymphony: EXECUTE -- loop {shortId})claudebinary path at first use viawhich/login-shell to handle Electron's restricted PATH; addassertPathAllowedsandbox gate; atomic PID write via.pid.tmprenameJSON.parse(...) as ExecutionResultcast with properisExecutionResulttype guard usingunknownintermediate and explicit shape checksPlan
https://app.closedloop.ai/implementation-plans/PLAN-108
Test plan