chore: lint

Author: coderaiser

.github/workflows/nodejs.yml

@@ -10,29 +10,34 @@ jobs:
     strategy:
       matrix:
         node-version:
-          - 16.x
-          - 18.x
-          - 19.x
+          - 22.x
+          - 24.x
+          - 25.x
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v5
+      - uses: oven-sh/setup-bun@v2
+        with:
+          bun-version: latest
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v6
         with:
           node-version: ${{ matrix.node-version }}
       - name: Install
-        run: npm i
+        run: bun i --no-save
       - name: Install Redrun, Lerna
-        run: npm i redrun -g
+        run: bun i redrun -g --no-save
       - name: Lint
         run: redrun fix:lint
       - name: Commit fixes
         uses: EndBug/add-and-commit@v9
+        continue-on-error: true
         with:
           message: "chore: ${{ env.NAME }}: actions: lint ☘️ "
       - name: Coverage
         run: redrun coverage report
       - name: Coveralls
-        uses: coverallsapp/github-action@master
+        uses: coverallsapp/github-action@v2
+        continue-on-error: true
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
       - name: typos-action

.madrun.js

@@ -11,11 +11,8 @@ module.exports = {
     'watch:coverage': () => run('watch', 'redrun coverage'),
     'coverage': () => 'c8 npm test',
     'report': () => 'c8 report --reporter=text-lcov | coveralls',
-    'lint:css': () => 'stylelint css/*.css',
-    'lint:js': () => 'putout lib .madrun.js webpack.config.js',
-    'lint': () => run('lint:*'),
-    'fix:lint': async () => await run(['lint:js', 'lint:css'], '--fix'),
+    'lint': () => 'putout .',
+    'fix:lint': async () => await run('lint', '--fix'),
     'test': () => `tape 'lib/**/*.spec.js'`,
     'test:update': () => 'UPDATE_FIXTURE=1 redrun test',
 };
-

.npmignore

@@ -10,3 +10,4 @@ yarn-error.log
 madrun.js
 
 coverage
+*.config.*

.stylelintrc

@@ -1,9 +1,7 @@
 'use strict';
 
 module.exports = ({autoSize, isTitle}) => {
-    const classNames = [
-        'modal-main',
-    ];
+    const classNames = ['modal-main'];
 
     if (autoSize)
         classNames.push('modal-autosize');
@@ -13,4 +11,3 @@ module.exports = ({autoSize, isTitle}) => {
 
     return classNames.join(' ');
 };
-

lib/get-class-name.js

@@ -49,4 +49,3 @@ test('get-class-name: autoSize, isTitle', (t) => {
     t.equal(result, expected);
     t.end();
 });
-

lib/get-class-name.spec.js

@@ -53,18 +53,18 @@ module.exports.open = (inner, options = {}) => {
     const isImage = isArray(inner);
     const isTitle = helpers.title && title || isImage;
 
-    const className = getClassName({autoSize, isTitle});
+    const className = getClassName({
+        autoSize,
+        isTitle,
+    });
 
     const el = createElement('div', {
         innerHTML,
         className,
         dataName: 'modal-main',
     });
 
-    addAllEvents('main', onMainClick(onOverlayClick), [
-        'click',
-        'contextmenu',
-    ]);
+    addAllEvents('main', onMainClick(onOverlayClick), ['click', 'contextmenu']);
 
     query('close').addEventListener('click', close);
 
@@ -125,4 +125,3 @@ function check(inner) {
     if (!inner)
         throw Error('inner should be DOM-element!');
 }
-

lib/modal.js

@@ -1,11 +1,13 @@
 'use strict';
 
-const tryCatch = require('try-catch');
+require('css-modules-require-hook/preset');
+
+const {tryCatch} = require('try-catch');
 
-const stub = require('@cloudcmd/stub');
 const mockRequire = require('mock-require');
 
-require('css-modules-require-hook/preset');
+const autoGlobals = require('auto-globals');
+const {test: tape, stub}= require('supertape');
 
 const {
     open,
@@ -14,22 +16,15 @@ const {
     _onMainClick,
 } = require('./modal');
 
-const autoGlobals = require('auto-globals');
-const tape = require('supertape');
-
 const {create} = autoGlobals;
 
-const {
-    reRequire,
-    stopAll,
-} = mockRequire;
+const {reRequire, stopAll} = mockRequire;
 
 const test = autoGlobals(tape);
 
 test('modal: open: main exist', (t) => {
     const el = {};
-    const query = stub()
-        .returns(el);
+    const query = stub().returns(el);
 
     mockRequire('./query', query);
 
@@ -64,7 +59,7 @@ test('modal: open: beforeShow', (t) => {
 
     stopAll();
 
-    t.ok(beforeShow.calledWith(), 'should call querySelector');
+    t.calledWithNoArgs(beforeShow, 'should call querySelector');
     t.end();
 });
 
@@ -134,6 +129,7 @@ test('modal: open: images', (t) => {
     }];
 
     const afterShow = stub();
+    
     open(images, {
         afterShow,
     });
@@ -154,7 +150,7 @@ test('modal: open: images', (t) => {
 
     stopAll();
 
-    t.ok(parseImages.calledWith(el, inner, options), 'should call querySelector');
+    t.calledWith(parseImages, [el, inner, options], 'should call querySelector');
     t.end();
 });
 
@@ -178,16 +174,13 @@ test('modal: onMainClick: no main', (t) => {
 
     _onMainClick(overlayClick, e);
 
-    t.notOk(overlayClick.called, 'should not call overlayClick');
+    t.notCalled(overlayClick, 'should not call overlayClick');
     t.end();
 });
 
 test('modal: close: removeChild', (t, {document}) => {
     const el = {};
-    const {
-        querySelector,
-        body,
-    } = document;
+    const {querySelector, body} = document;
 
     querySelector.returns(el);
     close();
@@ -198,10 +191,7 @@ test('modal: close: removeChild', (t, {document}) => {
 
 test('modal: close: removeChild: event', (t, {document}) => {
     const el = {};
-    const {
-        querySelector,
-        body,
-    } = document;
+    const {querySelector, body} = document;
 
     querySelector.returns(el);
     close();
@@ -223,7 +213,7 @@ test('modal: close: beforeClose', (t, {document}) => {
 
     close();
 
-    t.ok(beforeClose.calledWith(), 'should call beforeClose');
+    t.calledWithNoArgs(beforeClose, 'should call beforeClose');
     t.end();
 });
 
@@ -240,7 +230,7 @@ test('modal: close: afterClose', (t, {document}) => {
 
     close();
 
-    t.ok(afterClose.calledWith(), 'should call afterClose');
+    t.calledWithNoArgs(afterClose, 'should call afterClose');
     t.end();
 });
 
@@ -253,7 +243,6 @@ test('modal: close: no el', (t) => {
 
     close();
 
-    t.notOk(beforeClose.called, 'should not call afterClose');
+    t.notCalled(beforeClose, 'should not call afterClose');
     t.end();
 });
-

lib/modal.spec.js

@@ -27,11 +27,11 @@ const onKeydown = (img, images) => function keydownListener(e) {
 
     const {keyCode} = e;
 
-    if (keyCode === ArrowLeft)
+    if (keyCode === ArrowLeft) {
         --i;
-    else if (keyCode === ArrowRight)
+    } else if (keyCode === ArrowRight) {
         ++i;
-    else {
+    } else {
         if (keyCode === Esc)
             return document.body.removeEventListener('keydown', keydownListener);
 
@@ -52,10 +52,7 @@ function setImage(i, img, images) {
     query('nav-left').hidden = !i;
     query('nav-right').hidden = i === n;
 
-    const {
-        href,
-        title,
-    } = images[i];
+    const {href, title} = images[i];
 
     img.src = href;
     img.title = title;
@@ -92,11 +89,9 @@ function parseImages(parent, images, {afterShow, helpers, index}) {
     setImage(index, img, images);
     addListenerOnce(img, 'load', onload(parent, afterShow));
 
-    query('nav-left')
-        .addEventListener('click', prev(img, images));
+    query('nav-left').addEventListener('click', prev(img, images));
 
-    query('nav-right')
-        .addEventListener('click', next(img, images));
+    query('nav-right').addEventListener('click', next(img, images));
 
     document.body.addEventListener('keydown', onKeydown(img, images));
 }
@@ -126,4 +121,3 @@ module.exports._onKeydown = onKeydown;
 module.exports._indexStore = indexStore;
 module.exports._helpersStore = helpersStore;
 module.exports._onload = onload;
-