Skip to content

Commit 3860c69

Browse files
committed
chore(ci): remove the scheduled SyncerD workflow
It ran syncerd sync --once against a syncerd.yaml this repository has never contained, so it failed on every run since at least June, and its push trigger filtered on that same non existent path. The config discovery fix alongside this turns its failure from a baffling parse error into a clear one, which is an improvement to the message and not to the workflow. Removed rather than repaired. Making it work would mean deciding what this organisation wants mirrored and committing that as configuration, which is a product decision rather than a repair, and a workflow that has only ever failed teaches everyone to ignore a red mark on master.
1 parent ab5d7ea commit 3860c69

2 files changed

Lines changed: 3 additions & 96 deletions

File tree

.github/workflows/syncerd.yml

Lines changed: 0 additions & 96 deletions
This file was deleted.

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2121
- A failed state save on the fail-fast path was silent, so everything copied before the abort was copied again on the next run with no explanation
2222
- `git-sync` could not authenticate to Azure DevOps over git in `pat` mode, fixed in v0.2.1 and described there
2323

24+
### Removed
25+
- The `SyncerD` scheduled workflow, which ran `syncerd sync --once` against a `syncerd.yaml` this repository has never contained. It had failed on every run since at least June, and its push trigger filtered on a path that does not exist. Deleted rather than repaired: the dogfooding it was meant to do is not wanted, and a workflow that has only ever failed is worse than none
26+
2427
### Fixed
2528
- SyncerD parsed its own binary as its configuration. Config discovery accepted an extensionless file named `syncerd`, which is exactly what `make build` writes into the working directory, so running `./syncerd sync` beside the binary failed with `yaml: control characters are not allowed`, an error that points at nothing. Discovery now accepts only a real `syncerd.yaml` or `syncerd.yml`, and says where it looked when it finds neither
2629
- A mirrored pull request with no labels failed to update, taking the whole pull request with it. Once the mirror owned labels, an empty set was sent as null rather than as an empty array, and GitHub rejects that with 422. Most pull requests carry no labels, so this affected most of them. Found by the live suite on its first real run

0 commit comments

Comments
 (0)