Merge pull request #20 from clouddrove/fix/13-unit-tests

test: add unit tests

Author: clouddrove-ci

internal/registry/dockerhub_test.go

@@ -0,0 +1,23 @@
+package registry
+
+import "testing"
+
+func TestNormalizeDockerHubImage(t *testing.T) {
+	cases := []struct {
+		in   string
+		want string
+	}{
+		{"nginx", "library/nginx"},
+		{"library/nginx", "library/nginx"},
+		{"clouddrove/syncerd", "clouddrove/syncerd"},
+		{"docker.io/nginx", "library/nginx"},
+		{"docker.io/clouddrove/syncerd", "clouddrove/syncerd"},
+		{"index.docker.io/nginx", "library/nginx"},
+		{"index.docker.io/clouddrove/syncerd", "clouddrove/syncerd"},
+	}
+	for _, c := range cases {
+		if got := NormalizeDockerHubImage(c.in); got != c.want {
+			t.Errorf("NormalizeDockerHubImage(%q) = %q, want %q", c.in, got, c.want)
+		}
+	}
+}

internal/state/state_test.go

@@ -0,0 +1,67 @@
+package state
+
+import (
+	"path/filepath"
+	"testing"
+)
+
+func TestStateMarkAndIsSynced(t *testing.T) {
+	s := New()
+	if s.IsSynced("ecr", "library/nginx", "1.25") {
+		t.Fatal("fresh state should not report synced")
+	}
+	s.MarkSynced("ecr", "library/nginx", "1.25")
+	if !s.IsSynced("ecr", "library/nginx", "1.25") {
+		t.Fatal("expected marked tag to be synced")
+	}
+	// Unrelated dest/image/tag must stay unsynced.
+	if s.IsSynced("acr", "library/nginx", "1.25") {
+		t.Fatal("other destination must not be synced")
+	}
+	if s.IsSynced("ecr", "library/redis", "1.25") {
+		t.Fatal("other image must not be synced")
+	}
+	if s.IsSynced("ecr", "library/nginx", "1.26") {
+		t.Fatal("other tag must not be synced")
+	}
+}
+
+func TestStateNilSafe(t *testing.T) {
+	var s *State
+	if s.IsSynced("ecr", "library/nginx", "1.25") {
+		t.Fatal("nil state IsSynced must return false")
+	}
+}
+
+func TestStateSaveLoadRoundTrip(t *testing.T) {
+	path := filepath.Join(t.TempDir(), "nested", "state.json")
+
+	s := New()
+	s.MarkSynced("ecr", "library/nginx", "1.25")
+	s.MarkSynced("acr", "clouddrove/syncerd", "latest")
+	if err := s.Save(path); err != nil {
+		t.Fatalf("save: %v", err)
+	}
+
+	loaded, err := Load(path)
+	if err != nil {
+		t.Fatalf("load: %v", err)
+	}
+	if !loaded.IsSynced("ecr", "library/nginx", "1.25") {
+		t.Error("round-trip lost ecr/library/nginx:1.25")
+	}
+	if !loaded.IsSynced("acr", "clouddrove/syncerd", "latest") {
+		t.Error("round-trip lost acr/clouddrove/syncerd:latest")
+	}
+}
+
+func TestLoadMissingFileReturnsEmptyState(t *testing.T) {
+	path := filepath.Join(t.TempDir(), "does-not-exist.json")
+	s, err := Load(path)
+	if err != nil {
+		t.Fatalf("load missing: %v", err)
+	}
+	if s == nil || s.Synced == nil {
+		t.Fatal("expected initialized empty state")
+	}
+}

internal/sync/sync_test.go

@@ -0,0 +1,107 @@
+package sync
+
+import (
+	"context"
+	"errors"
+	"strings"
+	"testing"
+	"time"
+)
+
+func TestRetrySucceedsAfterFailures(t *testing.T) {
+	calls := 0
+	err := retry(context.Background(), 3, time.Millisecond, func() error {
+		calls++
+		if calls < 3 {
+			return errors.New("transient")
+		}
+		return nil
+	})
+	if err != nil {
+		t.Fatalf("expected success, got %v", err)
+	}
+	if calls != 3 {
+		t.Fatalf("expected 3 calls, got %d", calls)
+	}
+}
+
+func TestRetryReturnsLastError(t *testing.T) {
+	want := errors.New("boom")
+	calls := 0
+	err := retry(context.Background(), 2, time.Millisecond, func() error {
+		calls++
+		return want
+	})
+	if !errors.Is(err, want) {
+		t.Fatalf("expected last error %v, got %v", want, err)
+	}
+	if calls != 2 {
+		t.Fatalf("expected 2 calls, got %d", calls)
+	}
+}
+
+func TestRetryStopsOnCancelledContext(t *testing.T) {
+	ctx, cancel := context.WithCancel(context.Background())
+	cancel()
+	calls := 0
+	err := retry(ctx, 3, time.Millisecond, func() error {
+		calls++
+		return errors.New("transient")
+	})
+	if err == nil {
+		t.Fatal("expected error from cancelled context")
+	}
+	if calls != 0 {
+		t.Fatalf("expected fn not to run on cancelled context, got %d calls", calls)
+	}
+}
+
+func TestSlackCompactNewSyncs(t *testing.T) {
+	events := []SyncEvent{
+		{Destination: "ecr", Ref: "ecr.example.com/library/nginx:1.25"},
+		{Destination: "acr", Ref: "acr.example.com/library/nginx:1.25"},
+	}
+	msg := slackCompactNewSyncs(events)
+	if !strings.Contains(msg, "ecr.example.com/library/nginx:1.25") {
+		t.Errorf("compact message missing ref: %q", msg)
+	}
+	if !strings.Contains(msg, "new images/tags synced") {
+		t.Errorf("compact message missing header: %q", msg)
+	}
+}
+
+func TestSlackCompactNewSyncsTruncates(t *testing.T) {
+	var events []SyncEvent
+	for i := 0; i < 40; i++ {
+		events = append(events, SyncEvent{Ref: "ref"})
+	}
+	msg := slackCompactNewSyncs(events)
+	if !strings.Contains(msg, "and 15 more") {
+		t.Errorf("expected truncation note, got: %q", msg)
+	}
+}
+
+func TestSlackCompactFailures(t *testing.T) {
+	events := []FailureEvent{
+		{Destination: "ecr", Ref: "ecr.example.com/library/nginx:1.25", Error: "denied"},
+	}
+	msg := slackCompactFailures(events)
+	if !strings.Contains(msg, "denied") || !strings.Contains(msg, "sync failures") {
+		t.Errorf("failure message malformed: %q", msg)
+	}
+}
+
+func TestSlackDetailedGroupsByDestination(t *testing.T) {
+	events := []SyncEvent{
+		{Destination: "ecr", Ref: "a"},
+		{Destination: "ecr", Ref: "b"},
+		{Destination: "acr", Ref: "c"},
+	}
+	msg := slackDetailedNewSyncs(events)
+	if !strings.Contains(msg, "*ecr* (2)") {
+		t.Errorf("expected ecr group header, got: %q", msg)
+	}
+	if !strings.Contains(msg, "*acr* (1)") {
+		t.Errorf("expected acr group header, got: %q", msg)
+	}
+}