ci: let the pre-commit job fail (#105)

The job installed Terraform, TFLint and terraform-docs, then skipped two of them
and appended `|| true`, so it could not fail under any circumstance. Every green
"pre-commit checks" tick on this repository meant nothing.

That is not theoretical. Three genuine failures sat on master behind it: two
whitespace hooks, and a tflint unused-declaration that turned out to be a real
bug where spot_schedule_enabled did nothing at all (#104).

Drop the `|| true` and re-add the trailing newlines that #83 reintroduced, so
the gate passes on the current tree.

terraform_tflint stays skipped. It still reports
terraform_standard_module_structure against the examples, which use example.tf
rather than main.tf by CloudDrove convention across every module. That is a
convention decision rather than a defect, and re-enabling the hook belongs in
its own change alongside whatever is decided.

Author: clouddrove-ci

.github/workflows/automerge.yml

@@ -18,4 +18,4 @@ jobs:
       tfchecks_azure: '["tf-lint / tflint"]'
     secrets:
       GITHUB: ${{ secrets.GITHUB }}
-...
+...

.github/workflows/pr-auto-assignee.yml

@@ -13,4 +13,4 @@ jobs:
       GITHUB: ${{ secrets.GITHUB_TOKEN }}
     with:
       assignees: 'clouddrove-ci'
-...
+...

.github/workflows/pr-check.yml

@@ -8,4 +8,4 @@ jobs:
   pr-validation:
     if: github.actor != 'dependabot[bot]'
     uses: clouddrove/github-shared-workflows/.github/workflows/pr-checks.yml@v2
-...
+...

.github/workflows/pre-commit.yml

@@ -35,5 +35,14 @@ jobs:
         run: pip install pre-commit
 
       - name: Run pre-commit
-        run: SKIP=terraform_validate,terraform_tflint pre-commit run -a --show-diff-on-failure || true
-...
+        # No trailing `|| true`: this job installed Terraform, TFLint and
+        # terraform-docs and then could not fail, so three real hook failures sat
+        # on master unnoticed, including a tflint warning that turned out to be a
+        # genuine bug in spot_schedule_enabled.
+        #
+        # terraform_tflint stays skipped for now. It still reports
+        # terraform_standard_module_structure against the examples, which use
+        # example.tf rather than main.tf by CloudDrove convention. That is a
+        # convention decision, not a defect, and belongs in its own change.
+        run: SKIP=terraform_tflint pre-commit run -a --show-diff-on-failure
+...

.github/workflows/readme.yml

@@ -13,4 +13,4 @@ jobs:
     secrets:
       TOKEN : ${{ secrets.GITHUB }}
       SLACK_WEBHOOK_TERRAFORM: ${{ secrets.SLACK_WEBHOOK_TERRAFORM }}
-...
+...

.github/workflows/release-changelog.yml

@@ -12,4 +12,4 @@ jobs:
       tag_format: vX.Y.Z
       release_tag: ${{ github.ref_name }}
     secrets:
-      GITHUB: ${{ secrets.GITHUB_TOKEN }}
+      GITHUB: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/security-tfsec.yml

@@ -14,4 +14,4 @@ jobs:
     secrets: inherit
     with:
       working_directory: '.'
-...
+...

.github/workflows/tf-checks.yml

@@ -31,4 +31,4 @@ jobs:
       show_plan: false
     secrets:
       BUILD_ROLE: ${{ secrets.BUILD_ROLE }}
-...
+...

.github/workflows/tflint.yml

@@ -11,4 +11,4 @@ jobs:
     uses: clouddrove/github-shared-workflows/.github/workflows/tf-lint.yml@v2
     secrets:
       GITHUB: ${{ secrets.GITHUB_TOKEN }}
-...
+...

commitlint.config.cjs

@@ -3,10 +3,10 @@ module.exports = {
   rules: {
     'type-enum': [2, 'always', [
       'fix', 'feat', 'docs', 'ci', 'chore', 'test', 'refactor', 'style', 'perf', 'build', 'revert',
-      'Fix', 'Feat', 'Docs', 'Ci', 'Chore', 'Test', 'Refactor', 'Style', 'Perf', 'Build', 'Revert' 
+      'Fix', 'Feat', 'Docs', 'Ci', 'Chore', 'Test', 'Refactor', 'Style', 'Perf', 'Build', 'Revert'
       ]],
     'header-max-length': [2, 'always', 150],
     'subject-case': [0],
     'type-case': [0],
   }
-};
+};