fix(examples): move to the security-group 2.x rule schema and current keypair input

[clouddrove-ci]

Problem

tf-checks has been failing on master since at least 2026-06-02. The cause is in the examples, not the module: they pin current module versions while still passing arguments those versions removed.

Error: Unsupported argument
  on example.tf line 89, in module "http_https":
  89:   new_sg_ingress_rules_with_cidr_blocks = [{
An argument named "new_sg_ingress_rules_with_cidr_blocks" is not expected here.

Five arguments across both examples:

Passed	Pinned version	Current name
new_sg_ingress_rules_with_cidr_blocks (http_https, ssh)	security-group 2.0.3	new_sg_ingress_rules
new_sg_egress_rules_with_cidr_blocks (http_https, ssh)	security-group 2.0.3	new_sg_egress_rules
create_private_key_enabled (keypair)	keypair 1.3.4	enable_private_key

terraform init dies on these before reaching module "ec2-autoscale", so tf-checks never actually tests this module. Every PR inherits the red check.

Fix

Translate to the 2.x schema. Each rule is now one aws_vpc_security_group_ingress_rule or egress_rule and takes exactly one source, so rules that previously listed several CIDRs, or an IPv4 and an IPv6 range together, become one entry per source:

• http_https egress: one rule with cidr_blocks + ipv6_cidr_blocks becomes all-ipv4 and all-ipv6
• ssh ingress and egress: one rule spanning vpc_cidr_block and additional_cidr_block becomes one entry per CIDR

Effective access is unchanged. rule_count is gone, replaced by the required key, and protocol is now ip_protocol.

Verification

examples/on-demand: terraform init -> 0 errors, terraform validate -> Success!
examples/spot:      terraform init -> 0 errors, terraform validate -> Success!

terraform fmt -check -recursive clean.

Relationship to other PRs

Independent of #101 and #102, but #101's tf-checks cannot go green until this merges, since it fails on these same lines.