ci: update workflow triggers and references - #83
Merged
Conversation
vineetbavniya-cd
added
the
github_actions
hahirwar-cd
previously approved these changes
Apr 10, 2026
pranaydeokar-cd
approved these changes
Jun 2, 2026
Master gained a narrower fix for the same broken shared-workflow references this branch addresses (#102), which is what put the two in conflict. Resolved in favour of this branch: - pr-auto-assignee.yml keeps @v2. Pinning the shared workflows to a tag rather than @master is the point of this PR, and it is what would have prevented the breakage: a rename on the shared repository's master silently broke every caller. - tfsec.yml is deleted rather than kept. security-tfsec.yml supersedes it, so the fix master applied to the old file is redundant. No @master pins remain. Master's Terraform changes, the extra_tags fix and the security-group 2.x example migration, are unaffected.
Master gained the spot_schedule_enabled fix (#104), whose whitespace pass touched the same workflow files this branch rewrites. Resolved tf-checks.yml in favour of this branch: @v2 pinning, provider aws with OIDC through BUILD_ROLE, and enable_plan. Master's provider: none predates that and is what this PR is replacing.
clouddrove-ci
added a commit
that referenced
this pull request
Aug 6, 2026
The job installed Terraform, TFLint and terraform-docs, then skipped two of them and appended `|| true`, so it could not fail under any circumstance. Every green "pre-commit checks" tick on this repository meant nothing. That is not theoretical. Three genuine failures sat on master behind it: two whitespace hooks, and a tflint unused-declaration that turned out to be a real bug where spot_schedule_enabled did nothing at all (#104). Drop the `|| true` and re-add the trailing newlines that #83 reintroduced, so the gate passes on the current tree. terraform_tflint stays skipped. It still reports terraform_standard_module_structure against the examples, which use example.tf rather than main.tf by CloudDrove convention across every module. That is a convention decision rather than a defect, and re-enabling the hook belongs in its own change alongside whatever is decided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
🔄 Type of Change
🌍 Terraform Scope
✅ Checklist
terraform fmt -recursiveandterraform validatehave been executedterraform planhas been reviewed and changes are expected🧩 Terraform Version & Providers
🧪 Testing
terraform plan/applyTest Details:
📸 Screenshots / Documentation
🔗 Related Issues
Closes #
📝 Additional Notes