Repository navigation
Conversation
gregor-cf
force-pushed
the
gregor/tokio-quiche-improve-handling-of-waiting-streams
branch
from
October 6, 2026 17:45
008dcd6 to
2dcb302
Compare
Member
|
/bonk |
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
|
Review: 2 findings. The PR adds keyed, direction-aware waiting-stream tracking and updates cancellation tests. Two inline correctness comments were submitted; no additional security or style issues found. |
jrouviere
reviewed
Oct 7, 2026
ghedo
reviewed
Oct 8, 2026
ghedo
approved these changes
Oct 8, 2026
jrouviere
approved these changes
Oct 8, 2026
gregor-cf
force-pushed
the
gregor/tokio-quiche-improve-handling-of-waiting-streams
branch
from
October 8, 2026 16:16
2dcb302 to
97d1299
Compare
Lekensteyn
reviewed
Oct 15, 2026
| stream_id, direction | ||
| ); | ||
| debug_assert!(false, "{}", msg); | ||
| log::error!(ratelimit=60/m; "{}", msg); |
Contributor
There was a problem hiding this comment.
The ratelimit syntax was only added in foundations v5.6.0 while the Cargo.toml still permits foundations v4. This breaks cargo test when foundations v4.4.2 is installed.
@TheJokr @fisherdarling how important is foundations v4 compat?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.