Repository navigation
Conversation
Projects that use h3i only as a library had to build the packages that its command-line tool needs. For example, the tokio-quiche tests use h3i to send requests, but they also built the interactive prompt library and its terminal support. That's 14 packages the tests never used. The command-line tool and its interactive prompts now sit behind a new "cli" feature. The feature is on by default, so installing h3i still gives you the tool. Inside this workspace, h3i is used without the tool. Code that uses the prompts module with default features turned off must now turn on "cli". The tool's async mode also needs the "rt" feature of tokio. It worked only because tokio-quiche happened to turn that feature on. h3i now asks for it itself.
Contributor
|
/bonk |
|
LGTM! |
jrouviere
approved these changes
Oct 16, 2026
jrouviere
left a comment
jrouviere
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Nice to see you again!
hargut
approved these changes
Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projects that use h3i only as a library had to build the packages that
its command-line tool needs. For example, the tokio-quiche tests use
h3i to send requests, but they also built the interactive prompt
library and its terminal support. That's 14 packages the tests never
used.
The command-line tool and its interactive prompts now sit behind a new
"cli" feature. The feature is on by default, so installing h3i still
gives you the tool. Inside this workspace, h3i is used without the
tool.
Code that uses the prompts module with default features turned off
must now turn on "cli".
The tool's async mode also needs the "rt" feature of tokio. It worked
only because tokio-quiche happened to turn that feature on. h3i now
asks for it itself.