fix: add noopener,noreferrer to _blank targets to prevent reverse tab… - #442
Merged
Conversation
…nabbing
Opening attacker-influenced app/preview URLs in a new tab without
noopener leaves a live window.opener handle to the platform tab,
enabling reverse tabnabbing (CWE-1022). Add noopener,noreferrer to all
window.open('_blank') calls and rel=noopener noreferrer to target=_blank
anchors that were missing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nabbing
Opening attacker-influenced app/preview URLs in a new tab without noopener leaves a live window.opener handle to the platform tab, enabling reverse tabnabbing (CWE-1022). Add noopener,noreferrer to all window.open('_blank') calls and rel=noopener noreferrer to target=_blank anchors that were missing it.