fix: OAuth and login fixes - #446
Merged
Merged
Conversation
Auto-link a verified OAuth provider to an existing account instead of failing with a conflict, and return provider-specific messages when a user attempts email/password auth on an OAuth-only account. - findOrCreateOAuthUser: attach the new provider to the existing user (verified email) and sign them in rather than throwing 409 - login: distinguish a nonexistent email from an OAuth-only account and tell the user which provider to use - register: block password signup for an OAuth-only email with a clear provider-specific message - add providerLabel helper and a unit test for it
Replace the session-age delay with a CSRF-protected browser-session flow so users can connect Cloudflare immediately after signing in. Bind OAuth callbacks to the initiating session, scope PKCE cookies per flow, validate redirects, and centralize frontend initiation.
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.