Skip to content

refactor(pages): extract request stage - #3146

Draft
james-elicx wants to merge 11 commits into
codex/cdn-v2-pages-response-stagefrom
codex/cdn-v2-pages-request-stage
Draft

refactor(pages): extract request stage#3146
james-elicx wants to merge 11 commits into
codex/cdn-v2-pages-response-stagefrom
codex/cdn-v2-pages-request-stage

Conversation

@james-elicx

@james-elicx james-elicx commented Sep 2, 2026

Copy link
Copy Markdown
Member

Part 6 of 16 in the staged CDN adapter stack. Depends on #3145.

Summary

  • extracts Pages request routing and middleware orchestration into a request stage
  • delegates matched rendering through the transport-neutral Pages response-stage contract
  • preserves build reporting, production entry wiring, route behavior, and legacy single-entry output

Validation

  • focused Pages request-pipeline, worker-entry, deploy, and build-report tests
  • cumulative exact-tip changed-test sweep: 3,461 passed, 2 skipped
  • full exact-tip vp check

Review size

  • Implementation: +1114 / -347 LOC
  • Tests and fixtures: +1125 / -35 LOC
  • Other (docs, config, lockfile): +0 / -0 LOC
  • 15 changed files

Measured against codex/cdn-v2-pages-response-stage after rebasing onto main@a6931c0.

@pkg-pr-new

pkg-pr-new Bot commented Sep 2, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@vinext/cloudflare@3146
npm i https://pkg.pr.new/create-vinext-app@3146
npm i https://pkg.pr.new/@vinext/types@3146
npm i https://pkg.pr.new/vinext@3146

commit: 2548828

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Performance benchmarks

Compared 2548828 against base 0acbae4 using alternating same-runner rounds. Next.js was unchanged and skipped.

0 improved · 0 regressed · 6 within ±1.5%

Scenario Framework Baseline Current Change
Client bundle size (gzip) vinext 142.3 KB 142.3 KB ⚫ +0.0%
Client entry size (gzip) vinext 129.6 KB 129.6 KB ⚫ +0.0%
Dev server cold start vinext 3.32 s 3.30 s ⚫ -0.5%
Production build time vinext 3.80 s 3.78 s ⚫ -0.7%
RSC entry closure size (gzip) vinext 119.8 KB 119.8 KB ⚫ +0.0%
Server bundle size (gzip) vinext 203.4 KB 203.4 KB ⚫ +0.0%

View detailed results and traces

🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head

@james-elicx
james-elicx force-pushed the codex/cdn-v2-pages-request-stage branch 2 times, most recently from 500de66 to 8589d4f Compare September 2, 2026 09:49
@james-elicx
james-elicx force-pushed the codex/cdn-v2-pages-request-stage branch from 8589d4f to c399cd9 Compare September 2, 2026 12:47
@james-elicx
james-elicx force-pushed the codex/cdn-v2-pages-request-stage branch 2 times, most recently from 2247582 to ef5c1a7 Compare September 2, 2026 14:16
@james-elicx
james-elicx force-pushed the codex/cdn-v2-pages-request-stage branch from ef5c1a7 to 6d47050 Compare September 2, 2026 15:11
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor
Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original
workers-cache preview production
static-export preview production
web preview production

@james-elicx
james-elicx force-pushed the codex/cdn-v2-pages-request-stage branch 2 times, most recently from 04fc1cb to f60c5aa Compare September 2, 2026 16:32
@james-elicx
james-elicx force-pushed the codex/cdn-v2-pages-request-stage branch 2 times, most recently from 56be1e7 to 17550ea Compare September 2, 2026 16:46
@james-elicx
james-elicx force-pushed the codex/cdn-v2-pages-request-stage branch from 17550ea to 7ae4b04 Compare September 2, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant