Skip to content

Merge jammy to noble - #793

Merged
aramprice merged 116 commits into
ubuntu-noblefrom
merge-jammy-to-noble
Nov 3, 2026
Merged

aramprice merged 116 commits into
ubuntu-noblefrom
merge-jammy-to-noble

Conversation

@aramprice

Copy link
Copy Markdown
Member

Manual merge forward - github action can not update workflow files

dependabot Bot and others added 30 commits October 12, 2026 16:17
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.38.2 to 4.38.3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v4.38.2...v4.38.3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.38.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
bosh-cli needs to know whether a stemcell's agent accepts salted
HMAC-SHA256 mbus password verifiers before it puts one, rather than
the plaintext password, into VM metadata. Advertise agent capabilities
in stemcell.MF as an agent_features list.

The list stays empty until a separate PR bumps to a bosh-agent release
that supports verifiers and adds "http-password-hmac-sha256" in the
same change. Listing the feature with an older agent would make
create-env fail with a 401.

ai-assisted=yes
TNZ-129825

Co-Authored-By: Chris Selzo <chris.selzo@broadcom.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The stemcell manifest now includes an empty agent_features list, with specs checking the generated manifest and packaged stemcell.MF. The SBOM workflow uses an updated SARIF upload action. Two pipeline Git resources now use their repositories’ default branches, and a Dockerfile URL in a comment now points to main. The Ubuntu Jammy metalink records updated artifact hashes, sizes, version, and published timestamp.

Suggested reviewers: ramonskie, mkocher

Merge Risk: Minimal · up to daeb4

No actionable merge-blocking risk is identified in the manifest, CI-reference, workflow, or artifact-metadata updates. The change appears mergeable subject to normal checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description states the merge is manual because a GitHub Action cannot update workflow files. It gives the reason for the manual merge. It does not follow the repository template. It omits the merg… Expand the description to follow the repository template. State that this PR targets the oldest applicable branch (ubuntu-jammy to ubuntu-noble), and note that a maintainer must dispatch the merge-forward workflow for the next step. Add the…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title "Merge jammy to noble" names the main change, a forward merge from the ubuntu-jammy branch to ubuntu-noble. The changeset covers many files, so the title is broad. It does not describe the s…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Merge jammy to noble" names the main change, a forward merge from the ubuntu-jammy branch to ubuntu-noble. The changeset covers many files, so the title is broad. It does not describe the specific content of the merge, such as the SBOM SARIF action bump or the stemcell manifest change. The title is still a real and specific description of the PR's primary purpose.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 3 files. (2 skipped: 2 unsupported.)

Full details: Description check

Explanation

The description states the merge is manual because a GitHub Action cannot update workflow files. It gives the reason for the manual merge. It does not follow the repository template. It omits the merge-forward context (the target branch chain and the maintainer-dispatched workflow). It also has no AI Review Feedback section, which the template asks for.

Resolution

Expand the description to follow the repository template. State that this PR targets the oldest applicable branch (ubuntu-jammy to ubuntu-noble), and note that a maintainer must dispatch the merge-forward workflow for the next step. Add the AI Review Feedback section and confirm that all AI review comments are resolved or answered before review. Keep the existing reason for the manual merge.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 0e031a94-e955-443e-9744-84f342423ba1
Commits

Reviewing files that changed from the base of the PR and between e7ba944 and daeb431.

Files selected for processing: 6
  • .github/workflows/sbom.yml
  • bosh-stemcell/lib/bosh/stemcell/stemcell_packager.rb
  • bosh-stemcell/spec/bosh/stemcell/stemcell_packager_spec.rb
  • ci/pipeline-template.yml
  • ci/tasks/light-aws/build.sh
  • image-metalinks/ubuntu-jammy/ubuntu-jammy.meta4

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Nov 3, 2026
@aramprice
aramprice merged commit 3ee6715 into ubuntu-noble Nov 3, 2026
10 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Nov 3, 2026
@aramprice
aramprice deleted the merge-jammy-to-noble branch November 3, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants