Repository navigation
migrate rpc server to v3 cc api and prepare for future plugin interface refactoring #3751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jcvrabo
wants to merge
42
commits into
cloudfoundry:v8
Choose a base branch
from
jcvrabo:v8
base: v8
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
30c8667
remove option to fallback to legacy (already disabled, just removing …
jcvrabo 60d821e
simplify plugin command lookup
jcvrabo ab56eb1
move PluginCommandNames to Config method
jcvrabo 7b8a84c
replace RunPlugin with a PluginRunner
jcvrabo 267cb71
migrate coreconfig.Repository to configv3.Config for rpc service
jcvrabo 640a0ef
prepare rpc server to use v7action.Actor instead of legacy code
jcvrabo a8af34c
remove legacy configuration from plugin runner
jcvrabo bc2bec4
poc plugin v2-v3 migration with GetService call
jcvrabo a5b80ad
migrate v2-v3 CliRpcCmd simpler Get methods
jcvrabo bfa68e6
migrate v2-v3 CliRpcCmd.GetOrg
jcvrabo f9e397f
migrate v2-v3 CliRpcCmd.GetSpace
jcvrabo b5eef86
remove fallback to legacy code
jcvrabo 9730571
migrate v2-v3 CliRpcCmd.GetApp
jcvrabo 5c6ec8a
migrate CliRpcCmd.GetApps to v7action
jcvrabo 06c887d
migrate CallCoreCommand to use CommandParser instead of command runne…
jcvrabo 86a30bd
add cfclient to CliConnection
jcvrabo b415db7
deprecate plugin_models methods and refer to CfClient()
jcvrabo 7d7de9f
migrate CliRpcCmd.AccessToken and clean up
jcvrabo d8358b9
simplify NewRpcService signature, support output capture for core com…
jcvrabo 66ed149
update plugin app push test to reflect logs from the v7action instead…
jcvrabo 00ab227
resync upstream
jcvrabo c9c2b8a
fix fake cliConnetion
jcvrabo 4eec7ef
allow plugin invocation when no api/actor is currently available and …
jcvrabo a1b335d
remove legacy dependencies and dead code
jcvrabo 0a1f3a4
guarantee storage of updated tokens after refreshing
jcvrabo 3a16859
synchronize output during plugin execution
jcvrabo eba7304
refactor final plugin commands still using legacy code
jcvrabo 62b1d94
remove fallback to legacy
jcvrabo e2ed492
revert to returning the actual email for users
jcvrabo 5831ec6
backward compatible role mappings in plugin calls
jcvrabo 50891e7
return -1 for unset quotas
jcvrabo e19d145
fix security group deduplication bug
jcvrabo 5054c06
add service plan guid to v7action.ServiceInstance and use it in the p…
jcvrabo ceefa4b
map app state to legacy lowercase for plugins
jcvrabo 52a4f50
return just domain in Domain.Name
jcvrabo 3179ffa
return desired instances instead of running instances
jcvrabo ba26294
return environment variables and start command in GetApp
jcvrabo 2a1dc13
report service instance names in GetApp
jcvrabo 12a0269
display Get* calls warnings to stderr
jcvrabo 6929250
add comments mentioning requirements to refresh tokens with cfclient …
jcvrabo 69b6747
skip global options when finding plugin command
jcvrabo 4dfbdda
linting
jcvrabo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Minor] Unreachable legacy code is still being changed
After
62b1d947c, nothing reachescf/cmd.Mainanymore (it isn't linked into the binary), and the same goes forcf/commands/plugin/{install,uninstall}_plugin.go. These edits only keep the code compiling. Related leftovers that could go in the planned cleanup:plugin/rpc/run_plugin.go(RunMethodIfExists), which onlycf/cmduses;plugin/rpc/fakecommand/*, still dot-imported byplugin/rpc/cli_rpc_server_test.go;plugin/plugin_examples/test_rpc_server_example, which still importscf/flags.Not a blocker, but it would help to list these explicitly in the "follow-up" section so they don't get missed.