@@ -134,6 +134,57 @@ module VCAP::CloudController
134134 end
135135 end
136136
137+ describe 'validation of stored lifecycle data' do
138+ let ( :stored_stack ) { create ( :stack , name : 'some-stack' ) }
139+ let ( :app ) { create ( :app_model , :buildpack ) }
140+ let! ( :stored_buildpack ) { create ( :buildpack , name : 'some-buildpack' , stack : stored_stack . name ) }
141+
142+ before do
143+ app . lifecycle_data . update ( buildpacks : [ 'some-buildpack' ] , stack : stored_stack . name )
144+ end
145+
146+ context 'when the request does not include lifecycle data' do
147+ let ( :message ) { AppUpdateMessage . new ( lifecycle : { type : 'buildpack' , data : { } } ) }
148+
149+ it 'does not validate stored buildpacks' do
150+ expect ( BuildpackLifecycleFetcher ) . to receive ( :fetch ) . with ( [ ] , Stack . default . name , Lifecycles ::BUILDPACK ) . and_call_original
151+
152+ lifecycle = AppBuildpackLifecycle . new ( message , app )
153+
154+ expect ( lifecycle ) . to be_valid
155+ end
156+ end
157+
158+ context 'when the request clears lifecycle credentials' do
159+ let ( :message ) { AppUpdateMessage . new ( lifecycle : { type : 'buildpack' , data : { credentials : nil } } ) }
160+
161+ it 'does not validate stored buildpacks' do
162+ expect ( BuildpackLifecycleFetcher ) . to receive ( :fetch ) . with ( [ ] , Stack . default . name , Lifecycles ::BUILDPACK ) . and_call_original
163+
164+ lifecycle = AppBuildpackLifecycle . new ( message , app )
165+
166+ expect ( lifecycle ) . to be_valid
167+ end
168+ end
169+
170+ context 'when credentials are updated without buildpacks' do
171+ let ( :message ) do
172+ AppUpdateMessage . new ( lifecycle : {
173+ type : 'buildpack' ,
174+ data : { credentials : { 'buildpacks.example.org' => { username : 'user' , password : 'password' } } }
175+ } )
176+ end
177+
178+ it 'validates the stored buildpacks against the stored stack' do
179+ expect ( BuildpackLifecycleFetcher ) . to receive ( :fetch ) . with ( [ 'some-buildpack' ] , stored_stack . name , Lifecycles ::BUILDPACK ) . and_call_original
180+
181+ lifecycle = AppBuildpackLifecycle . new ( message , app )
182+
183+ expect ( lifecycle ) . to be_valid
184+ end
185+ end
186+ end
187+
137188 describe '#create_lifecycle_data_model with credentials' do
138189 context 'when credentials are provided' do
139190 let ( :creds ) { { 'git.example.com' => { 'username' => 'u' , 'password' => 'p' } } }
0 commit comments