Skip to content

Commit da4c3d5

Browse files
authored
fix: Document AssessTables category scope and use single coverage reason field (#41)
1 parent f28a782 commit da4c3d5

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

‎plugin/v3/plugin.proto‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,7 @@ message TestConnection {
248248
}
249249

250250
message AssessTables {
251+
// TABLE_REMOVED applies to tables only, all other values apply to tables and columns
251252
enum Category {
252253
CATEGORY_UNKNOWN = 0;
253254
CATEGORY_NO_CHANGE = 1;
@@ -268,6 +269,7 @@ message AssessTables {
268269
string before = 2;
269270
string after = 3;
270271
}
272+
// Safe mode is a migration with migrate_force false, forced mode with migrate_force true
271273
message ColumnFinding {
272274
string column_name = 1;
273275
Category category = 2;
@@ -285,8 +287,8 @@ message AssessTables {
285287
string forced_mode_behavior = 4;
286288
repeated ColumnFinding columns = 5;
287289
repeated Evidence evidence = 6;
288-
bool coverage_incomplete = 7;
289-
string coverage_incomplete_reason = 8;
290+
// Non-empty when the assessment could not cover the whole table
291+
string incomplete_coverage_reason = 7;
290292
}
291293
message Request {
292294
repeated TablePair tables = 1;

0 commit comments

Comments
 (0)