Skip to content

Commit b636a3a

Browse files
cloudwebrtcclaude
andcommitted
ci: validate kept rc changesets in --check and document flow overlap
Parse every changeset kept from an rc release up front, so a broken one fails the PR check instead of the stable release. Note in the README that manual and changeset release PRs don't close each other. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 6801ed2 commit b636a3a

2 files changed

Lines changed: 9 additions & 0 deletions

File tree

‎.changeset/README.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,3 +54,8 @@ bump type. It opens a `release/<prefix>-v<version>` PR without reading any
5454
changeset; merging it publishes the same way as a changeset release PR.
5555
It doesn't touch `.changeset/`, so changesets kept from rc releases stay until
5656
that package's next changeset stable release.
57+
58+
The two flows don't know about each other: a manual bump doesn't close an open
59+
`Release: ...` changeset PR for the same package (or the other way round), and
60+
both change that package's version, so once one merges the other conflicts.
61+
Close the stale one before merging.

‎.github/changesets.py‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,10 @@ def main(rc_only: bool, notes: pathlib.Path | None, repo: str | None, check: boo
194194
f"changesets kept from rc releases are missing: {missing} "
195195
f"(restore them, or remove them from {PRE_STATE} on purpose)"
196196
)
197+
# Parse them now too, so a broken kept changeset fails the PR check
198+
# instead of the stable release.
199+
for name in sorted(kept):
200+
parse_changeset(CHANGESET_DIR / name)
197201
files = sorted(
198202
p
199203
for p in CHANGESET_DIR.glob("*.md")

0 commit comments

Comments
 (0)