fix(ark): expose Responses API model name on messages - #942
Open
jesseedcp wants to merge 1 commit into
Open
Conversation
|
@hi-pender Sorry to bother you. Could you take a look at this PR and see if it makes sense? PTAL~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
<type>(optional scope): <description>(Optional) Translate the PR title into Chinese.
fix(ark): 在 Responses API 消息中暴露模型名称(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
The Ark Chat Completions path exposes the resolved model name on
schema.Messagethroughark.GetModelName, while the Responses API currently reports it only through callback extra.This change reuses the existing message-extra mechanism to preserve
ResponseObject.Modelon non-streaming output messages and streaming response metadata chunks. As a result, callers can retrieve the model name from both non-streaming messages and concatenated streaming messages throughark.GetModelName.No public API or dependency changes are introduced.
Tests:
go test -gcflags="all=-N -l" ./...go vet ./...go test -race -gcflags="all=-N -l" . -run '^TestResponsesAPIChatModelPreservesModelName$' -count=1(Optional) Which issue(s) this PR fixes:
Fixes #941
(optional) The PR that updates user documentation:
N/A