refactor(route): remove unreachable akind branch in backtrackToNextNodeKind - #1536
Open
lxcxjxhx wants to merge 1 commit into
Open
refactor(route): remove unreachable akind branch in backtrackToNextNodeKind#1536lxcxjxhx wants to merge 1 commit into
lxcxjxhx wants to merge 1 commit into
Conversation
…deKind When backtracking from an akind node, previous.kind is always skind or pkind because entering an anyChild node always breaks the search loop immediately. The `if previous.kind == akind` branch was dead code. Simplifies the logic to `nextNodeKind = previous.kind + 1`. Closes cloudwego#1504
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the dead
if previous.kind == akindbranch inbacktrackToNextNodeKind()and simplify tonextNodeKind = previous.kind + 1.Why
When backtracking from an akind node,
previous.kindis alwaysskindorpkindbecause entering ananyChildnode always breaks the search loop immediately (line 447). Theif previous.kind == akindbranch was unreachable dead code.Evidence:
panic("unreachable")to the branch and runninggo test ./...passes without triggeringChanges
tree.go: removeif previous.kind == akindbranch, simplify tonextNodeKind = previous.kind + 1(net -9 lines)Testing
All existing tests pass. This is a pure refactor removing dead code.
Closes #1504