Skip to content

refactor(route): remove unreachable akind branch in backtrackToNextNodeKind #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lxcxjxhx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(route): remove unreachable akind branch in backtrackToNextNodeKind #1536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions pkg/route/tree.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,12 +324,10 @@ func (r *router) find(path string, paramsPointer *param.Params, unescape bool) (
cn = previous.parent
valid = cn != nil

// Next node type by priority
if previous.kind == akind {
nextNodeKind = skind
} else {
nextNodeKind = previous.kind + 1
}
// Next node type by priority.
// previous.kind is never akind here: when we enter an anyChild node
// we break immediately, so backtracking always starts from skind or pkind.
nextNodeKind = previous.kind + 1

if fromKind == skind {
// when backtracking is done from static kind block we did not change search so nothing to restore
Expand Down