fix(resp): correct ConnectionUpgrade to check for Upgrade instead of keep-alive - #1537
Open
lxcxjxhx wants to merge 1 commit into
Open
fix(resp): correct ConnectionUpgrade to check for Upgrade instead of keep-alive#1537lxcxjxhx wants to merge 1 commit into
lxcxjxhx wants to merge 1 commit into
Conversation
…keep-alive ConnectionUpgrade() was checking for the "keep-alive" value instead of "Upgrade" in the Connection header. This caused WebSocket upgrade responses to be incorrectly identified, potentially breaking WebSocket support by setting Transfer-Encoding: identity and closing the connection. Fix by using bytestr.StrUpgrade instead of bytestr.StrKeepAlive.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
ConnectionUpgrade()inresp/header.gowhich was incorrectly checking forkeep-aliveinstead ofUpgradein the Connection header.Why
The function name and comment clearly state it should check for
Connection: Upgrade, but the implementation was usingbytestr.StrKeepAliveinstead ofbytestr.StrUpgrade.This bug affects WebSocket support: when a response has
Connection: Upgrade(as in WebSocket handshakes),ConnectionUpgrade()returnsfalse, causing the code at line 204 to incorrectly setTransfer-Encoding: identityand close the connection.Conversely, regular keep-alive responses would incorrectly trigger the upgrade path.
Changes
resp/header.go: changebytestr.StrKeepAlivetobytestr.StrUpgradeinConnectionUpgrade()Testing
All existing tests pass. This is a one-line bug fix.