Merge pull request #52 from clue-labs/unhandled-rejections

Update idle handler to avoid unhandled promise rejections

Author: clue

src/SshSocksConnector.php

@@ -198,6 +198,8 @@ public function idle()
             $this->idleTimer = $this->loop->addTimer($this->idlePeriod, function () use (&$listen, $debug) {
                 $listen->then(function (Process $process) {
                     $process->terminate();
+                }, function () {
+                    // ignore to avoid reporting unhandled rejection
                 });
                 $listen->cancel();
                 $listen = null;

tests/IntegrationSshSocksConnectorTest.php

@@ -118,6 +118,24 @@ public function testConnectWillRejectWithExceptionAndTerminateIdleProcessWhenSoc
         $this->assertTrue($process->isTerminated());
     }
 
+    public function testConnectCancellationWillRejectWithException()
+    {
+        $connector = new SshSocksConnector('host');
+
+        $ref = new \ReflectionProperty($connector, 'cmd');
+        if (PHP_VERSION_ID < 80100) {
+            $ref->setAccessible(true);
+        }
+        $ref->setValue($connector, 'exec sleep 10; #');
+
+        $promise = $connector->connect('example.com:80');
+        $promise->cancel();
+
+        $promise->then(null, $this->expectCallableOnceWith($this->isInstanceOf('RuntimeException')));
+
+        Loop::run();
+    }
+
     public function testConnectWillRejectWithExceptionAndTerminateProcessWhenProcessOutputsLineExceedingMaximumBufferSize()
     {
         $connector = new SshSocksConnector('host');