Skip to content

Commit 9aa9be2

Browse files
ampagentIsaac Miller
andcommitted
Record second-round managed-auth review fixes
Signed-off-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a0c095-4917-7617-9dac-e99f1ef22d41 Co-authored-by: Isaac Miller <isaac@cmpnd.ai>
1 parent dd900d2 commit 9aa9be2

1 file changed

Lines changed: 11 additions & 0 deletions

File tree

‎DOWNSTREAM_PATCHES.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,17 @@ unpatched and do not rewrite published integration branches.
5959
finished after the deadline. The public regression in tests/test_login.py
6060
now gets AuthOperationError(reason="login_expired"), persists no credential,
6161
and can start a new login immediately. This patch is downstream only.
62+
9. `dd900d292a393c6c04fab7d1c57248dfee25e90b`: preserve the originally
63+
requested route through renewal and re-resolve it at dispatch admission.
64+
A newly saved or signed-out route-specific slot must supersede the shared
65+
owner even for an already prepared request. Run durable async login
66+
cancellation on an independent executor so a blocked login cannot occupy
67+
the only worker available to release its reservation. The second Greptile
68+
review reproduced both races. Four sync/async route replacement/logout
69+
cases and two one-worker cancellation cases fail before and pass after.
70+
Cancellation frees the reservation before the login worker is released;
71+
it does not interrupt blocking terminal input or undo a completed commit.
72+
These fixes are downstream only, pending upstream contribution access.
6273

6374
The first four patches remain necessary in v1.3.0. Its Meta login changes supply
6475
the minted endpoint and plan; they do not change bound selection, renewal

0 commit comments

Comments
 (0)